Re: RFR: 8041626: [Event Request] Shutdown reason

gards, Robin > > Mandy > > On 2/15/18 5:35 AM, Robin Westberg wrote: >> Hi again, >> >> Here’s the (hopefully) final version: >> >> Full: http://cr.openjdk.java.net/~rwestberg/8041626/webrev.02/ >> <http://cr.openjdk.java.net/%7Erwestberg/804162

Re: RFR: 8041626: [Event Request] Shutdown reason

gt; > > On 2/15/2018 8:35 AM, Robin Westberg wrote: >> Hi again, >> >> Here’s the (hopefully) final version: >> >> Full: http://cr.openjdk.java.net/~rwestberg/8041626/webrev.02/ >> <http://cr.openjdk.java.net/%7Erwestberg/8041626/webrev.02/>

Re: RFR: 8041626: [Event Request] Shutdown reason

g/8041626/webrev.01-02/> Best regards, Robin > On 14 Feb 2018, at 16:15, Robin Westberg wrote: > > Hi Roger, > >> On 13 Feb 2018, at 16:17, Roger Riggs wrote: >> >> Hi Robin, >> >> It looks like the status argument to BeforeHalt is discarded in &

Re: RFR: 8041626: [Event Request] Shutdown reason

Hi Alan, > On 12 Feb 2018, at 09:02, Alan Bateman wrote: > > > > On 12/02/2018 07:07, David Holmes wrote: >> >>> Okay, I’ve removed the code related to the status field, certainly makes >>> the change a bit less intrusive. >>> >>> Updated webrev: http://cr.openjdk.java.net/~rwestberg/804162

Re: RFR: 8041626: [Event Request] Shutdown reason

Hi David, > On 12 Feb 2018, at 08:07, David Holmes wrote: > > Hi Robin, > > On 10/02/2018 1:41 AM, Robin Westberg wrote: >> Hi David, >>> On 9 Feb 2018, at 05:22, David Holmes >> <mailto:david.hol...@oracle.com> <mailto:david.hol...@oracle.com

Re: RFR: 8041626: [Event Request] Shutdown reason

Updated webrev: http://cr.openjdk.java.net/~rwestberg/8041626/webrev.01/ <http://cr.openjdk.java.net/~rwestberg/8041626/webrev.01/> Incremental: http://cr.openjdk.java.net/~rwestberg/8041626/webrev.00-01/ <http://cr.openjdk.java.net/~rwestberg/8041626/webrev.00-01/> Best regards,

Re: RFR: 8041626: [Event Request] Shutdown reason

Hi Erik, > On 7 Feb 2018, at 21:47, Erik Gahlin wrote: > > Hi Robin, > > I can sponsor this. > > I wonder if we should change the name of the event to "Shutdown" instead? It > will give us flexibility to add other shutdown related fields in the future. Makes sense, I’ll rename it. > Could y

Re: RFR: 8041626: [Event Request] Shutdown reason

gh. Best regards, Robin > > Thanks, Roger > > > On 2/8/2018 10:50 AM, Robin Westberg wrote: >> Hi David, >> >>> On 8 Feb 2018, at 04:28, David Holmes wrote: > ... >>> I had an initial look through this. >>> >>> To be honest I d

Re: RFR: 8041626: [Event Request] Shutdown reason

hing else happens during the shutdown sequence like a finalizer calling exit (in which case you could possibly end up with two shutdown events, but both may contain interesting information). Best regards, Robin > Let's see what others think ... > > Thanks, > David > > O

Re: RFR: 8041626: [Event Request] Shutdown reason

Hi Alan, > On 7 Feb 2018, at 16:30, Alan Bateman wrote: > > On 07/02/2018 15:18, Robin Westberg wrote: >> Hi all, >> >> Please review the following change that adds an event-based tracing event >> that is generated when the VM shuts down. The intent is to

RFR: 8041626: [Event Request] Shutdown reason

Hi all, Please review the following change that adds an event-based tracing event that is generated when the VM shuts down. The intent is to capture shutdowns that occur after the VM has been properly initialized (as initialization problems would most likely mean that the tracing framework hasn