Re: RFR:JDK-8146747:java.time.Duration.toNanos() and toMillis() exception on negative durations

2016-02-04 Thread ShinyaYoshida
wrote: > >> Hi Shinya, >> Thnx. I will update it. >> Regards, >> Nadeesh >> On 2/3/2016 5:41 PM, ShinyaYoshida wrote: >> >>> Hi Nadeesh, >>> Almost LGTM!(But I'm not a reviewer;) ) >>> However I've noticed that you don't

Re: RFR:JDK-8146747:java.time.Duration.toNanos() and toMillis() exception on negative durations

2016-02-03 Thread ShinyaYoshida
Hi Nadeesh, Almost LGTM!(But I'm not a reviewer;) ) However I've noticed that you don't use NANOS_PER_SECOND at L1223 and L1246. Is there some reason not to use it? Regards, shinyafox(Shinya Yoshida) 2016-02-01 15:18 GMT+09:00 nadeesh tv : > Hi all, > > Please review following > > Bug Id : https

Re: RFR 8144675: Add a filtering collector

2015-12-10 Thread ShinyaYoshida
from that department to an empty > {@code Set}. If a stream {@code filter()} operation were done instead, > there would be no mapping for that department at all. » > > s'marks > > > > > On 12/8/15 4:21 AM, ShinyaYoshida wrote: > >> Hi Stefan, >> Thank you

Re: RFR 8144675: Add a filtering collector

2015-12-08 Thread ShinyaYoshida
dEmployeesByDeparetment/wellPaidEmployeesByDepartment > > > Regards, > Stefan > > > 2015-12-08 13:04 GMT+01:00 ShinyaYoshida : > > Thank you so much! > > I've updated in webrev.02. > > > > Best regard, > > shinyafox(Shinya Yoshida) > > >

Re: RFR 8144675: Add a filtering collector

2015-12-08 Thread ShinyaYoshida
Thank you so much! I've updated in webrev.02. Best regard, shinyafox(Shinya Yoshida) 2015-12-08 20:25 GMT+09:00 Paul Sandoz : > > > On 8 Dec 2015, at 10:59, ShinyaYoshida wrote: > > > > Hi Paul, > > Thank you for your review. > > (Especially, about doc com

Re: RFR 8144675: Add a filtering collector

2015-12-08 Thread ShinyaYoshida
filtering(e -> > e.getSalary() > 2000, toset(; > > > (Since we don’t specify the monetary units, it is left as an exercise to > speculate whether this is well paid or not :-) ). > > > 472 * @param filter a predicate to be applied to the input elements >

Re: RFR 8144675: Add a filtering collector

2015-12-07 Thread ShinyaYoshida
still necessary and useful for other situations. Regards, shinyafox(Shinya Yoshida) 2015-12-04 15:57 GMT+09:00 ShinyaYoshida : > Hi, core-libs-dev and Brian, Paul, > I'd like to propose adding filtering method to Collectors. > > When I consider the operation what is "grouping the

Re: RFR 8144675: Add a filtering collector

2015-12-07 Thread ShinyaYoshida
Hi Paul, Thank you for your answer. I've just updated my webrev to use 9: http://cr.openjdk.java.net/~shinyafox/8144675/webrev.01/ Regards, shinyafox(Shinya Yoshida) 2015-12-07 17:31 GMT+09:00 Paul Sandoz : > > On 7 Dec 2015, at 03:45, ShinyaYoshida wrote: > > Hi, > I&#x

Re: RFR 8144675: Add a filtering collector

2015-12-06 Thread ShinyaYoshida
Hi, I'd like to wait for the review, but I have a trivial question: Which @since is preferred, 1.9 or 9? For ex, at Optional#or and stream, @since 9 is used. On the other hand, at Collectors#flatMap, @since 1.9 is used. Regards, shinyafox(Shinya Yoshida) 2015-12-05 22:18 GMT+09:00 Paul Sandoz

Re: RFR 8144675: Add a filtering collector

2015-12-04 Thread ShinyaYoshida
rs#filtering): http://ideone.com/83Lzb7 filtering before collecting(Stream#filter): http://ideone.com/EmTrXE Regards, shinyafox(ShinyaYoshida) > > Cheers, > Henry > > > > > On Dec 3, 2015, at 10:57 PM, ShinyaYoshida wrote: > > > > Hi, core-libs-dev and

RFR 8144675: Add a filtering collector

2015-12-04 Thread ShinyaYoshida
Hi, core-libs-dev and Brian, Paul, I'd like to propose adding filtering method to Collectors. When I consider the operation what is "grouping the number of employees whose income is over 2000 by the depertment from employees", we have to write following because there is no way to filter for Collec