Re: Review Request: 8001533: Java launcher must launch JavaFX applications

2012-11-15 Thread Steve Sides
FXLauncherTest.java - very good test that covers many test cases. Do you plan to add the classpath case (i.e. not from a jar file)? I hadn't, but if it's worthwhile then we could certainly add a test to do so. Thoughts on this Steve? I added it to the test plan to be implemented after in

Re: 7197491: update copyright year to match last edit in jdk8 jdk repository

2012-11-02 Thread Steve Sides
On 11/2/2012 9:47 AM, Kelly O'Hair wrote: It looked fine to me. One of the reasons this has fallen through the cracks so much is because nobody has any time to do it. Completely automating it is risky, and it needs to be reviewed. So it needs an official owner and I agree. You can't completel

Re: 7197491: update copyright year to match last edit in jdk8 jdk repository

2012-11-02 Thread Steve Sides
On 11/2/2012 5:46 AM, Alan Bateman wrote: Now for some noise. The copyright date in the source files needs updating. The man behind the curtain is Steve Sides from the Quality and Release Engineering team in Oracle. Jon pushed, on Steve's behalf, the update to the langtools files rec

Heads up: large sets of copyright year updates going into jdk8/tl/jdk

2012-10-13 Thread Steve Sides
Hi All, This is a heads up notice, all files in jdk repositories which have been updated in 2012, and have not had the copyright year updated, are now doing so. All other repositories have completed this chore and we've saved this largest for last. Individually, each of these changes is tri