Re: RFR: 8243453: Option --describe-module failed with non-ASCII module name under non-UTF8 environment

2020-04-27 Thread Toshio 5 Nakamura
Hi Alan, Thank you for the review. May I ask your help for sponsoring this fix? Best Regards, Toshio Nakamura Alan Bateman wrote on 2020/04/24 17:50:39: > On 24/04/2020 09:33, Toshio 5 Nakamura wrote: > > Hi all, > > > > Please review this fix. > > Also, I'd like

RFR: 8243453: Option --describe-module failed with non-ASCII module name under non-UTF8 environment

2020-04-24 Thread Toshio 5 Nakamura
Hi all, Please review this fix. Also, I'd like to ask a sponsor of the fix, since I'm not a committer. Issue: https://bugs.openjdk.java.net/browse/JDK-8243453 Webrev: http://cr.openjdk.java.net/~tnakamura/8243453/webrev.00/ Under Windows Japanese or Chinese, encoding of command line option

Re: RFR: 8232846: ProcessHandle.Info command with non-English shows question marks

2020-03-27 Thread Toshio 5 Nakamura
Hi Roger, Thank you so much for the review and being sponsor this fix. Best regards, Toshio > From: Roger Riggs > > Hi Toshio, > > Looks good, > > I can sponsor it. > > Thanks, Roger > > On 3/27/20 6:46 AM, Toshio 5 Nakamura wrote: > > Thank you for r

Re: RFR: 8232846: ProcessHandle.Info command with non-English shows question marks

2020-03-27 Thread Toshio 5 Nakamura
; > > Thanks, > > Yasumasa > > On 2020/03/27 18:10, Toshio 5 Nakamura wrote: > > Hi Suenaga-san, > > Thank you for the comment. I updated the limit to 32768. > > webrev.02: https://urldefense.proofpoint.com/v2/url?u=http-3A__cr.openjdk.java.net_-7Etnakamura_8232846_w

Re: RFR: 8232846: ProcessHandle.Info command with non-English shows question marks

2020-03-26 Thread Toshio 5 Nakamura
t; >>> > >>> The stack allocated buffer (1024) is fine, but I'd suggest > adding code to retry in the case > >>> of INSUFFICIENT BUFFER with a malloc'd buffer to make it more > robust since the enabling > >>> of long paths is environment and application specif

Re: RFR: 8232846: ProcessHandle.Info command with non-English shows question marks

2020-03-26 Thread Toshio 5 Nakamura
processimagenamew=DwICaQ=jf_iaSHvJObTbx-siA1ZOg=EVbFABcgo-X99_TGI2-qsMtyulHUruf8lAzMlVpVRqw=noFyLWDG1dMjO5TlaqM_zvW_f-8fvveS2EoZylT5DMQ=oc_KTGmJUjsfnLf3tjWr9DO1dwWp1TqIZgd2EiHVW14= > > > > > > On 2020/03/26 17:58, Toshio 5 Nakamura wrote: > >> > >> Hi All, > >> >

RFR: 8232846: ProcessHandle.Info command with non-English shows question marks

2020-03-26 Thread Toshio 5 Nakamura
Hi All, Could you review this change? Additionally, I'd like to ask a sponsor for it, since I'm not a committer. Bug: https://bugs.openjdk.java.net/browse/JDK-8232846 Webrev: http://cr.openjdk.java.net/~tnakamura/8232846/webrev.00 Under Windows environments, ProcessHandle.Info.command shows

Re: [13] RFR: 8220227: Host Locale Provider getDisplayCountry returns error message under non-English Win10

2019-03-11 Thread Toshio 5 Nakamura
Hi Naoto-san, Thank you for reviewing the fix. Could you re-review the updated webrev? http://cr.openjdk.java.net/~tnakamura/8220227/webrev.01/ Thanks, Toshio Nakamura naoto.s...@oracle.com wrote on 2019/03/09 02:39:48: > From: naoto.s...@oracle.com > To: Toshio 5 Nakamura , 18n-

[13] RFR: 8220227: Host Locale Provider getDisplayCountry returns error message under non-English Win10

2019-03-07 Thread Toshio 5 Nakamura
Hi, Could you review this fix? I'd like to have a sponsor of it, since I'm an author. Bug: https://bugs.openjdk.java.net/browse/JDK-8220227 Webrev: http://cr.openjdk.java.net/~tnakamura/8220227/webrev.00/ Issue: Under Windows 10 non-English, Locale.getDisplayCountry() shows an error message,

JDK-8042131: Proposal of Mapped-values formatter for non-IsoChronology

2018-06-15 Thread Toshio 5 Nakamura
Hello core-libs and i18n folks, We'd like to request to reconsider JDK-8042131, "DateTimeFormatterBuilder Mapped-values do not work for JapaneseDate". The report was posted by our team long time ago, and was closed as not an issue. At that time, the feature was for only IsoChronology. Now, I