Re: RFR: 8252990: Intrinsify Unsafe.storeStoreFence [v2]

2021-10-29 Thread Wang Huang
On Thu, 28 Oct 2021 08:58:48 GMT, Aleksey Shipilev wrote: >> `Unsafe.storeStoreFence` currently delegates to stronger >> `Unsafe.storeFence`. We can teach compilers to map this directly to already >> existing rules that handle `MemBarStoreStore`. Like explicit >> `LoadFence`/`StoreFence`, we i

Re: RFR: 7008363: TEST_BUG: test/java/lang/StringCoding/CheckEncodings.sh does nothing and is very slow at that

2021-10-19 Thread Wang Huang
On Mon, 18 Oct 2021 20:49:07 GMT, Naoto Sato wrote: > Removing a problem-listed test case, which has little value in itself. > Confirmed it did succeed on all platforms before the removal. Marked as reviewed by whuang (Author). - PR: https://git.openjdk.java.net/jdk/pull/5996

Integrated: 8268231: Aarch64: Use ldp in intrinsics for String.compareTo

2021-10-09 Thread Wang Huang
On Thu, 8 Jul 2021 11:50:36 GMT, Wang Huang wrote: > Dear all, > Can you do me a favor to review this patch. This patch use `ldp` to > implement String.compareTo. > > * We add a JMH test case > * Here is the result of this test case > > Benchmark

Re: RFR: 8268231: Aarch64: Use ldp in intrinsics for String.compareTo [v7]

2021-08-29 Thread Wang Huang
us/op > StringCompare.compareUUWithLdp| 121 | avgt| 5 |16.597| ±0.016|us/op > StringCompare.compareUUWithLdp| 181 | avgt| 5 |27.373| ±0.017|us/op > StringCompare.compareUUWithLdp| 256 | avgt| 5 |41.74 | ±3.5 |us/op > > From this table, we can see that in most ca

Re: RFR: 8268231: Aarch64: Use ldp in intrinsics for String.compareTo [v6]

2021-08-06 Thread Wang Huang
us/op > StringCompare.compareUUWithLdp| 121 | avgt| 5 |16.597| ±0.016|us/op > StringCompare.compareUUWithLdp| 181 | avgt| 5 |27.373| ±0.017|us/op > StringCompare.compareUUWithLdp| 256 | avgt| 5 |41.74 | ±3.5 |us/op > > From this table, we can see that in most ca

Re: RFR: 8268231: Aarch64: Use ldp in intrinsics for String.compareTo [v4]

2021-08-03 Thread Wang Huang
On Thu, 15 Jul 2021 03:30:46 GMT, Wang Huang wrote: >> Dear all, >> Can you do me a favor to review this patch. This patch use `ldp` to >> implement String.compareTo. >> >> * We add a JMH test case >> * Here is the result

Re: RFR: 8268231: Aarch64: Use ldp in intrinsics for String.compareTo [v5]

2021-08-03 Thread Wang Huang
us/op > StringCompare.compareUUWithLdp| 121 | avgt| 5 |16.597| ±0.016|us/op > StringCompare.compareUUWithLdp| 181 | avgt| 5 |27.373| ±0.017|us/op > StringCompare.compareUUWithLdp| 256 | avgt| 5 |41.74 | ±3.5 |us/op > > From this table, we can see that in most ca

Re: RFR: 8268231: Aarch64: Use ldp in intrinsics for String.compareTo [v4]

2021-07-14 Thread Wang Huang
us/op > StringCompare.compareUUWithLdp| 121 | avgt| 5 |16.597| ±0.016|us/op > StringCompare.compareUUWithLdp| 181 | avgt| 5 |27.373| ±0.017|us/op > StringCompare.compareUUWithLdp| 256 | avgt| 5 |41.74 | ±3.5 |us/op > > From this table, we can see that in most ca

Re: RFR: 8268231: Aarch64: Use ldp in intrinsics for String.compareTo [v3]

2021-07-14 Thread Wang Huang
On Wed, 14 Jul 2021 08:27:36 GMT, Nick Gasson wrote: >> Wang Huang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> refact codes > > src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 4990: >

Re: RFR: 8268231: Aarch64: Use ldp in intrinsics for String.compareTo [v3]

2021-07-13 Thread Wang Huang
us/op > StringCompare.compareUUWithLdp| 121 | avgt| 5 |16.597| ±0.016|us/op > StringCompare.compareUUWithLdp| 181 | avgt| 5 |27.373| ±0.017|us/op > StringCompare.compareUUWithLdp| 256 | avgt| 5 |41.74 | ±3.5 |us/op > > From this table, we can see that in most ca

Re: RFR: 8268231: Aarch64: Use ldp in intrinsics for String.compareTo [v2]

2021-07-12 Thread Wang Huang
On Mon, 12 Jul 2021 15:36:29 GMT, Andrew Haley wrote: > And with longer strings, M1 and ThunderX2: > > ``` > Benchmark (diff_pos) (size) Mode Cnt > Score Error Units > StringCompare.compareLLDiffStrings10231024 avgt3 >

Re: RFR: 8268231: Aarch64: Use ldp in intrinsics for String.compareTo [v2]

2021-07-12 Thread Wang Huang
us/op > StringCompare.compareUUWithLdp| 121 | avgt| 5 |16.597| ±0.016|us/op > StringCompare.compareUUWithLdp| 181 | avgt| 5 |27.373| ±0.017|us/op > StringCompare.compareUUWithLdp| 256 | avgt| 5 |41.74 | ±3.5 |us/op > > From this table, we can see that in most ca

Re: RFR: 8268231: Aarch64: Use ldp in intrinsics for String.compareTo

2021-07-12 Thread Wang Huang
On Fri, 9 Jul 2021 09:15:18 GMT, Andrew Haley wrote: > I'm quite tempted to approve this. It looks generally better, simpler, and > easier to understand than what we have today. However, the improvement isn't > great, and I suspect is mostly because of the reduction in traffic between > Base a

RFR: 8268231: Aarch64: Use ldp in intrinsics for String.compareTo

2021-07-08 Thread Wang Huang
Dear all, Can you do me a favor to review this patch. This patch use `ldp` to implement String.compareTo. * We add a JMH test case * Here is the result of this test case Benchmark |(size)| Mode| Cnt|Score | Error |Units -|-