Re: RFR: 8048199: Replace anonymous inner classes with lambdas, where applicable, in JNDI [v2]

2021-04-25 Thread YassinHajaj
On Mon, 12 Apr 2021 16:12:17 GMT, Daniel Fuchs wrote: >> Conor Cleary has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Update copyright headers >> - Tidied up lambdas > > src/java.naming/share/classes/com/sun/jndi/ldap/LdapPoolManager.

Re: RFR: 8037397: RegEx pattern matching loses character class after intersection (&&) operator [v2]

2021-04-25 Thread YassinHajaj
On Fri, 2 Apr 2021 15:44:23 GMT, Ian Graves wrote: >> Ian Graves has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixing missing space > > Tagging with CSR because this will impact a long-standing (buggy) behavior. Hi @igraves , If you

Re: RFR: 8263668: Update java.time to use instanceof pattern variable [v7]

2021-04-22 Thread YassinHajaj
On Thu, 22 Apr 2021 10:13:32 GMT, Patrick Concannon wrote: >> I was able to find (with IntelliJ IDEA help) few more places to improve >> >> java.time 27 warnings >> class Clock 2 warnings >> class FixedClock 1 warning >> method equals(Object) 1