Re: [9] RFR: 8150702: change in javadoc for parseObject for MessageFormat - JDK-8073211

Hi, Your fix look good to me. We cannot change current behavior for backward compatibility. Thanks, -- Yuka On 2016/03/04 15:51, vaibhav x.choudhary wrote: Hello, Please review this small fix for jdk9/dev repo :- Bug: https://bugs.openjdk.java.net/browse/JDK-8150702 Webrev: http://cr.openjdk

Re: RFR: JDK-8087104: DateFormatSymbols triggers this.clone() in the constructor

Hi Ramanand, Your fix looks good to me. Thanks, -- Yuka On 2016/03/02 14:34, Ramanand Patil wrote: Hi all, May I request one more review for this bug? [Thank you Masayoshi for your review.] Regards, Ramanand. -Original Message- From: Masayoshi Okutsu Sent: Wednesday, February 24,

[9] RFR: 8072600: Unicode 8 support

Hello, Please review a small change for 8072600: Unicode 8 support. Mainly date update from Unicode 7. JEP: http://openjdk.java.net/jeps/267 Issue: https://bugs.openjdk.java.net/browse/JDK-8072600 webrev: http://cr.openjdk.java.net/~peytoia/8072600/ Thanks, -- Yuka

Re: RFR: 8138716: (tz) Support tzdata2015g

Hi Aleksej, Looks good to me. Thanks, -- Yuka On 2015/10/03 2:47, Aleksej Efimov wrote: Hi, Please, help to review the latest tzdata integration [1] fix to JDK9: http://cr.openjdk.java.net/~aefimov/tzdata/2015g/9/00/index.html Testing shows no failures in time zones related tests. With Bes

RFR: 8032446: Support Unicode 7.0.0 in JDK 9

Hello, Please review the fix for 8032446 to support Unicode 7 in JDK 9. https://bugs.openjdk.java.net/browse/JDK-8032446 http://cr.openjdk.java.net/~peytoia/8032446/webrev.00/ - Internal review for both open & closed parts has been completed. - Changes in sun.text.* packages are mostly porting f

Re: RFR: 8043012: (tz) Support tzdata2014c

Hi, The fix looks good to me. Thanks, -- Yuka (5/15/14, 7:59), Aleksej Efimov wrote: Hello, Can I have a review for the tzdata2014c integration to JDK9. This is a standard release of tzdata (except the hurry with Egypt rules - the main part in this release). The following set of tests was e

hg: jdk8/tl/jdk: 8029057: test/java/text/Bidi/Bug6665028.java can fail with OutOfMemoryError

Changeset: 4d9078b1f25b Author:peytoia Date: 2013-11-26 14:49 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4d9078b1f25b 8029057: test/java/text/Bidi/Bug6665028.java can fail with OutOfMemoryError Reviewed-by: okutsu - test/java/text/Bidi/Bug6665028.java

hg: jdk8/tl/jdk: 8020037: String.toLowerCase incorrectly increases length, if string contains \u0130 char

Changeset: e8683d5b2b0a Author:peytoia Date: 2013-10-22 06:13 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e8683d5b2b0a 8020037: String.toLowerCase incorrectly increases length, if string contains \u0130 char Reviewed-by: naoto ! src/share/classes/java/lang/ConditionalSpe

RFR: 8020037: String.toLowerCase incorrectly increases length, if string contains \u0130 char

Hi, This is a backout of wrong fix added in jdk 7. https://bugs.openjdk.java.net/browse/JDK-8020037 http://cr.openjdk.java.net/~peytoia/8020037/webrev.00/ Thanks, -- Yuka

hg: jdk8/tl/jdk: 8025703: Update LSR datafile for BCP 47

Changeset: ce266885222d Author:peytoia Date: 2013-10-17 13:57 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ce266885222d 8025703: Update LSR datafile for BCP 47 Reviewed-by: okutsu ! src/share/classes/sun/util/locale/LocaleEquivalentMaps.java + test/java/util/Locale/Bug8025

Re: RFR JDK-8020054: (tz) Support tzdata2013d

Hi Sherman, The fix looks good to me. Thanks, -- Yuka (2013/08/09 14:54), Xueming Shen wrote: Hi, Please help review the proposed change to update the tz data in JDK8 from 2013c to 2013d. http://cr.openjdk.java.net/~sherman/8020054/webrev http://cr.openjdk.java.net/~sherman/8020054/closed

hg: jdk8/tl/jdk: 8021108: Clean up doclint warnings and errors in java.text package

Changeset: 6cc15a808b93 Author:peytoia Date: 2013-07-26 17:22 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6cc15a808b93 8021108: Clean up doclint warnings and errors in java.text package Reviewed-by: darcy, okutsu ! src/share/classes/java/text/Annotation.java ! src/share/c

hg: jdk8/tl/jdk: 8009638: Wrong comment for PL in LocaleISOData, 1989 forward Poland is Republic of Poland

Changeset: 006a7a576fe9 Author:peytoia Date: 2013-04-11 12:22 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/006a7a576fe9 8009638: Wrong comment for PL in LocaleISOData, 1989 forward Poland is Republic of Poland Reviewed-by: okutsu ! src/share/classes/java/util/LocaleISODat

hg: jdk8/tl/jdk: 8005277: Regression in JDK 7 in Bidi implementation

Changeset: 1da019e7999a Author:peytoia Date: 2012-12-28 15:07 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1da019e7999a 8005277: Regression in JDK 7 in Bidi implementation Reviewed-by: okutsu ! src/share/classes/sun/text/bidi/BidiBase.java ! test/java/text/Bidi/BidiConform

hg: jdk8/tl/jdk: 8001209: Evaluate findbugs reprot for java.text.ChoiceFormat

Changeset: 98a47dc23296 Author:peytoia Date: 2012-11-02 23:17 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/98a47dc23296 8001209: Evaluate findbugs reprot for java.text.ChoiceFormat Reviewed-by: okutsu ! src/share/classes/java/text/ChoiceFormat.java + test/java/text/Format/

hg: jdk8/tl/jdk: 7201151: Fix Contribution : Java cannot get Windows's IME name correctly

Changeset: 8692e14b8ea8 Author:peytoia Date: 2012-10-04 18:05 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8692e14b8ea8 7201151: Fix Contribution : Java cannot get Windows's IME name correctly Reviewed-by: okutsu ! src/windows/native/sun/windows/awt_InputMethod.cpp

hg: jdk8/tl/jdk: 7196316: Wrong rounding mode in DecimalFormat after deserialization

Changeset: 123db1c28d92 Author:peytoia Date: 2012-10-04 11:36 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/123db1c28d92 7196316: Wrong rounding mode in DecimalFormat after deserialization Reviewed-by: okutsu ! src/share/classes/java/text/DecimalFormat.java + test/java/text

hg: jdk8/tl/jdk: 7104012: AIOOBE from RuleBasedBreakIterator.lookupState for some suppl. chars

Changeset: 4744dc70e5d1 Author:peytoia Date: 2012-10-03 15:11 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4744dc70e5d1 7104012: AIOOBE from RuleBasedBreakIterator.lookupState for some suppl. chars Reviewed-by: okutsu ! src/share/classes/sun/text/SupplementaryCharacterData

Re: [8] Review request for JEP 127: Improve Locale Data Packaging and Adopt Unicode CLDR Data

Hi, It looks good to me. Thanks, -- Yuka (12/08/21 2:14), Naoto Sato wrote: I have updated the changeset by removing the copyright headers from all of the CLDR files, and added a LICENSE file at the top of CLDR source directory (src/share/classes/sun/util/cldr/resources/21_0_1). No other cha

hg: jdk8/tl/jdk: 7158483: (tz) Support tzdata2012c

Changeset: d0e8c9361bc0 Author:peytoia Date: 2012-04-03 11:52 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d0e8c9361bc0 7158483: (tz) Support tzdata2012c Reviewed-by: okutsu ! make/sun/javazic/tzdata/VERSION ! make/sun/javazic/tzdata/africa ! make/sun/javazic/tzdata/antarc

hg: jdk8/tl/jdk: 7070436: Support Unicode 6.1.0 in JDK 8

Changeset: b2687ac9cffb Author:peytoia Date: 2012-03-29 18:02 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b2687ac9cffb 7070436: Support Unicode 6.1.0 in JDK 8 Reviewed-by: okutsu ! make/tools/GenerateCharacter/CharacterData00.java.template ! make/tools/UnicodeData/PropLis

hg: jdk8/tl/jdk: 7017458: (cal) Multithreaded deserialization of Calendar leads to ClassCastException

Changeset: ceab7e149581 Author:peytoia Date: 2012-01-26 17:06 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ceab7e149581 7017458: (cal) Multithreaded deserialization of Calendar leads to ClassCastException Reviewed-by: okutsu ! src/share/classes/java/util/Calendar.java + t

hg: jdk8/tl/jdk: 7116914: Miscellaneous warnings (sun.text)

Changeset: ca383e32deaf Author:peytoia Date: 2011-12-06 08:39 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ca383e32deaf 7116914: Miscellaneous warnings (sun.text) Reviewed-by: smarks, okutsu ! src/share/classes/sun/text/CompactByteArray.java ! src/share/classes/sun/text/In

Re: Request for Review: 7116914 (Miscellaneous warnings (sun.text))

garding the "throw syntaxError()" change, yes that would be a bit too much > of > a refactoring to perform in the context of warnings cleanup. > > s'marks > > On 12/4/11 7:24 PM, Yuka Kamiya wrote: >> Hi, >> >> Mike, Stuart, Alan, an

Re: Request for Review: 7116914 (Miscellaneous warnings (sun.text))

7;t issue a warning), smaller change is better. (The policy may change in the future, though.) Thanks, -- Yuka (11/12/02 16:51), Yuka Kamiya wrote: > Hello, > > Could someone please review this fix? > > http://cr.openjdk.java.net/~peytoia/7116914/webrev.00/ > > Some

Request for Review: 7116914 (Miscellaneous warnings (sun.text))

uture. The original number of warnings in this area was 70. Now 16. Thanks, -- Yuka Kamiya

hg: jdk8/tl/jdk: 7056472: Speed up test/java/util/ResourceBundle/Control/ExpirationTest.sh

Changeset: b03da32c3186 Author:peytoia Date: 2011-12-02 16:09 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b03da32c3186 7056472: Speed up test/java/util/ResourceBundle/Control/ExpirationTest.sh Reviewed-by: okutsu - test/java/util/ResourceBundle/Control/ExpirationTest.java

hg: jdk8/tl/jdk: 7090046: Lots of invalid link in java.text.BreakIterator comments

Changeset: 0d371f2911a1 Author:peytoia Date: 2011-10-26 22:16 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0d371f2911a1 7090046: Lots of invalid link in java.text.BreakIterator comments Reviewed-by: okutsu ! src/share/classes/java/text/BreakIterator.java

hg: jdk8/tl/jdk: 7103405: Correct display names for Pacific/Apia timezone

Changeset: db9e246c651e Author:peytoia Date: 2011-10-21 18:01 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/db9e246c651e 7103405: Correct display names for Pacific/Apia timezone Reviewed-by: okutsu ! src/share/classes/sun/util/resources/TimeZoneNames.java ! src/share/classe

hg: jdk8/tl/jdk: 7103108: (tz) Support tzdata2011l

Changeset: d979afceb792 Author:peytoia Date: 2011-10-21 15:56 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d979afceb792 7103108: (tz) Support tzdata2011l Reviewed-by: okutsu ! make/sun/javazic/tzdata/VERSION ! make/sun/javazic/tzdata/asia ! make/sun/javazic/tzdata/australa

hg: jdk8/tl/jdk: 7090843: (tz) Support tzdata2011j

Changeset: 5e403e9fa34a Author:peytoia Date: 2011-09-15 15:02 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5e403e9fa34a 7090843: (tz) Support tzdata2011j Reviewed-by: okutsu ! make/sun/javazic/tzdata/VERSION ! make/sun/javazic/tzdata/africa ! make/sun/javazic/tzdata/antarc

hg: jdk8/tl/jdk: 7090844: Support a timezone whose offset is changed more than once in the future

Changeset: f114bddac6d6 Author:peytoia Date: 2011-09-15 14:45 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f114bddac6d6 7090844: Support a timezone whose offset is changed more than once in the future Reviewed-by: okutsu ! make/tools/src/build/tools/javazic/Mappings.java

hg: jdk8/tl/jdk: 7012364: test/java/util/Locale/LocaleCategory.sh fails on Cygwin

Changeset: 5adf431673ac Author:peytoia Date: 2011-07-12 07:32 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5adf431673ac 7012364: test/java/util/Locale/LocaleCategory.sh fails on Cygwin Reviewed-by: okutsu ! test/java/util/Locale/LocaleCategory.sh

Re: Codereview request for 7033561: Missing Unicode Script aliases

Hi Sherman, The fix looks good to me. Thanks, -- Yuka (11/04/07 5:16), Xueming Shen wrote: It appears the aliases mapping for Character.UnicodeScript is not updated accordingly when we upgraded the Unicode support to 6.0 for JDK7. The difference between the previous version (5.2) and 6.0 of