Re: RFR: 8042126: DateTimeFormatter "MMMMM" returns English value in Japanese locale

2014-08-06 Thread dmeetry degrave
good to me. Naoto On 8/5/14, 3:41 AM, dmeetry degrave wrote: Hello, Please review a simple fix (jdk 8 and 9) for 8042126: DateTimeFormatter "M" returns English value in Japanese locale bug: https://bugs.openjdk.java.net/browse/JDK-8042126 fix: http://cr.openjdk.java.net/~dmeet

RFR: 8042126: DateTimeFormatter "MMMMM" returns English value in Japanese locale

2014-08-05 Thread dmeetry degrave
Hello, Please review a simple fix (jdk 8 and 9) for 8042126: DateTimeFormatter "M" returns English value in Japanese locale bug: https://bugs.openjdk.java.net/browse/JDK-8042126 fix: http://cr.openjdk.java.net/~dmeetry/8042126/webrev.01 thanks, dmeetry

Re: RFR: 8044671: NPE from JapaneseEra when a new era is defined in calendar.properties

2014-07-31 Thread dmeetry degrave
copyright year range should be updated. Otherwise, the fix looks good to me. Masayoshi On 7/23/2014 11:51 PM, dmeetry degrave wrote: Hello, Please review a simple fix (jdk 8 and 9) for 8044671: NPE from JapaneseEra when a new era is defined in calendar.properties bug: https

RFR: 8044671: NPE from JapaneseEra when a new era is defined in calendar.properties

2014-07-23 Thread dmeetry degrave
Hello, Please review a simple fix (jdk 8 and 9) for 8044671: NPE from JapaneseEra when a new era is defined in calendar.properties bug: https://bugs.openjdk.java.net/browse/JDK-8044671 fix: http://cr.openjdk.java.net/~dmeetry/8044671/webrev.01 No automated regression test, unfortunately, it

Re: [7u backport] RFR: 7122142: (ann) Race condition between isAnnotationPresent and getAnnotations

2014-03-03 Thread dmeetry degrave
Hi all, I would like to ask someone with a reviewer status in jdk7u project to look at these changes. thanks, dmeetry On 02/27/2014 05:44 PM, Joel Borggren-Franck wrote: Hi, I looked at webrev.1. Looks good. cheers /Joel On 2014-02-25, dmeetry degrave wrote: Thanks for looking at this

Re: [7u backport] RFR: 7122142: (ann) Race condition between isAnnotationPresent and getAnnotations

2014-02-24 Thread dmeetry degrave
Thanks for looking at this, Peter! On 02/24/2014 04:42 PM, Peter Levart wrote: Hi Dmeetry, On 02/22/2014 01:22 PM, dmeetry degrave wrote: Hi all, I would like to ask for a review of combined back port for 7u-dev/7u80. The main goal is to have a fix for 7122142 in jdk7, it also integrates the

[7u backport] RFR: 7122142: (ann) Race condition between isAnnotationPresent and getAnnotations

2014-02-22 Thread dmeetry degrave
Hi all, I would like to ask for a review of combined back port for 7u-dev/7u80. The main goal is to have a fix for 7122142 in jdk7, it also integrates the changes from 8005232, 7185456, 8022721 https://bugs.openjdk.java.net/browse/JDK-7122142 https://bugs.openjdk.java.net/browse/JDK-8005232 h

RFR: [corba] 4504275, 8011986 - two issues with generated code

2013-04-12 Thread Dmeetry Degrave
Hi all, I'm looking for a review for two ancient issues in idlj. First is an issue with uncompilable java code generated for unions with boolean discriminator. 4504275: CORBA boolean type unions do not generate compilable code from idlj bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id

RFR: 7199858: Marshal exception is wrong

2013-02-11 Thread Dmeetry Degrave
Hi, Resending a code review request for a corba fix for 7 and 8, which is identical to fix went to earlier releases. A wrong unexpectedUnionDefault exception is thrown in TypeCode handling code when an OptUnion value with false discriminator is inserted into any of NV struct on server side f

RFR: 7199858: Marshal exception is wrong

2012-12-20 Thread Dmeetry Degrave
Hi, I'm looking for a code review for a corba fix for 7 and 8, which is identical to fix went to earlier releases. A wrong "IOP00810247: (MARSHAL) Default union branch not expected" exception is thrown for discriminated unions with no matching discriminator and no default cases, while Sectio

(corba) code review for 7046238: new InitialContext(); hangs

2011-12-11 Thread Dmeetry Degrave
Hi, I'm looking for an approval for 7046238, "new InitialContext(); hangs". It was fixed in 6u27(b02) and we need it in 7u4 & jdk8. Fix is identical in all releases and it was approved by Ken for 6. initial description: http://bugs.sun.com/view_bug.do?bug_id=7016182 evaluation: http://bugs.s