Withdrawn: JDK-8282798 java.lang.runtime.Carrier

2022-05-26 Thread duke
On Tue, 8 Mar 2022 14:02:39 GMT, Jim Laskey wrote: > We propose to provide a runtime anonymous carrier class object generator; > java.lang.runtime.Carrier. This generator class is designed to share > anonymous classes when shapes are similar. For example, if several clients > require objects c

Withdrawn: 8283726: x86 intrinsics for compare method in Integer and Long

2022-05-26 Thread duke
On Sun, 27 Mar 2022 06:15:34 GMT, Srinivas Vamsi Parasa wrote: > Implements x86 intrinsics for compare() method in java.lang.Integer and > java.lang.Long. This pull request has been closed without being integrated. - PR: https://git.openjdk.java.net/jdk/pull/7975

Withdrawn: JDK-8277095 : Empty streams create too many objects

2022-05-26 Thread duke
On Fri, 5 Nov 2021 12:53:46 GMT, kabutz wrote: > This is a draft proposal for how we could improve stream performance for the > case where the streams are empty. Empty collections are common-place. If we > iterate over them with an Iterator, we would have to create one small > Iterator object

Withdrawn: 8282178: Replace simple iterations of Map.entrySet with Map.forEach calls

2022-05-19 Thread duke
On Wed, 23 Feb 2022 22:33:42 GMT, liach wrote: > Replaces simple `for (Map.Entry entry : map.entrySet())` with > `map.forEach((k, v) ->)` calls. This change is better for thread-safety and > reduces allocation for some map implementations. > > A more in-depth description of benefits is availab

Withdrawn: 8003417: WeakHashMap$HashIterator removes wrong entry

2022-01-31 Thread duke
On Sat, 20 Nov 2021 10:08:41 GMT, Jaikiran Pai wrote: > Can I please get a review for this change which proposes to fix the issue > reported in https://bugs.openjdk.java.net/browse/JDK-8003417? > > The issue notes that this is applicable for `WeakHashMap` which have `null` > keys. However, the

Withdrawn: JDK-8277375: jdeps errors on a class path with a file path with no permission

2022-01-27 Thread duke
On Wed, 24 Nov 2021 01:12:01 GMT, Mandy Chung wrote: > This changes jdeps -cp to ignore files/directories with no permission to > access. This is consistent with the runtime behavior. This pull request has been closed without being integrated. - PR: https://git.openjdk.java.net/j

Withdrawn: JDK-8276939: Fix AbstractLdapNamingEnumeration next to throw NoSuchElementException instead of NullPointerException

2022-01-13 Thread duke
On Sun, 24 Oct 2021 16:27:02 GMT, andrewluotechnologies wrote: > `AbstractLdapNamingEnumeration` `next` throws `NullPointerException` instead > of `NoSuchElementException`, however the javadoc for `NamingEnumeration` says > that next should throw `NoSuchElementException` when no elements are

Withdrawn: 8277015: Use blessed modifier order in Panama code

2022-01-12 Thread duke
On Thu, 11 Nov 2021 14:50:43 GMT, Magnus Ihse Bursie wrote: > I ran bin/blessed-modifier-order.sh on source owned by Project Panama. This > scripts verifies that modifiers are in the "blessed" order, and fixes it > otherwise. I have manually checked the changes made by the script to make > sur

Withdrawn: 8277013: Allow creation of module graphs without defining modules to the VM

2022-01-07 Thread duke
On Thu, 11 Nov 2021 14:53:13 GMT, Ivan Ristović wrote: > Related JBS issue: https://bugs.openjdk.java.net/browse/JDK-8277013 > > The GraalVM Native Image module support must create the runtime boot-module > layer at image build time; module instances created at build time need to > reflect mod

Withdrawn: 8273101: Eliminate the usage of threadgroup sandboxing in the java.util.logging

2022-01-06 Thread duke
On Wed, 1 Sep 2021 06:31:16 GMT, Sergey Bylokhov wrote: > At the time Java supported applets and webstart, a special mechanism for > launching various applications in one JVM was used to reduce memory usage and > each application was isolated from each other. > > This isolation was implemented

Withdrawn: 8271598: CDS classlist file should support uber JARs

2021-12-04 Thread duke
On Sat, 9 Oct 2021 00:15:43 GMT, Calvin Cheung wrote: > Currently, for archive classes for custom loaders, CDS supports the following > source locations in the classlist: This pull request has been closed without being integrated. - PR: https://git.openjdk.java.net/jdk/pull/5876

Withdrawn: 8217496: Matcher.group() can return null after usePattern

2021-11-30 Thread duke
On Tue, 5 Oct 2021 19:11:57 GMT, Ian Graves wrote: > Specification update to clarify Matcher behavior to include a null return > value. This pull request has been closed without being integrated. - PR: https://git.openjdk.java.net/jdk/pull/5827

Withdrawn: 8217501: Matcher.hitEnd returns false for incomplete surrogate pairs

2021-11-22 Thread duke
On Mon, 27 Sep 2021 21:16:11 GMT, Ian Graves wrote: > Fixing a bug where character matcher doesn't mark hitEnd as true if it's a > code point with more than one character. This pull request has been closed without being integrated. - PR: https://git.openjdk.java.net/jdk/pull/5725

Withdrawn: JDK-8272192 Shortcut String equality checks by checking equality of the value array

2021-11-02 Thread duke
On Sat, 4 Sep 2021 11:59:58 GMT, q2q-2q2 wrote: > Shortcut String equality checks by checking equality of the value array This pull request has been closed without being integrated. - PR: https://git.openjdk.java.net/jdk/pull/5370

Withdrawn: 8268788: Annotations with lambda expressions can still cause AnnotationFormatError

2021-10-22 Thread duke
On Wed, 30 Jun 2021 20:08:27 GMT, Sergei Ustimenko wrote: > Change #3294 helps to avoid `AnnotaionFormatException` in > `sun.reflect.annotation.AnnotationInvocationHandler.validateAnnotationMethods`. > While it fixes the case with e.g. `Runnable` that generates the synthetic > method without

Withdrawn: 8153490: Cannot setBytes() if incoming buffer's length is bigger than number of elements we want to insert.

2021-10-13 Thread duke
On Wed, 12 May 2021 17:48:50 GMT, Mitsuru Kariya wrote: > Fix `SerialBlob.setBytes(long pos, byte[] bytes, int offset, int length)` in > the following cases: > > 1. `pos - 1 + bytes.length - offset > this.length() && pos - 1 + length <= > this.length()` >The original implementation throws

Withdrawn: 8270057: Use Objects.checkFromToIndex for j.u.c.CopyOnWriteArrayList

2021-09-14 Thread duke
On Thu, 8 Jul 2021 11:51:18 GMT, Yi Yang wrote: > After JDK-8265518(#3615), it's possible to replace all variants of checkIndex > by Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in > the whole JDK codebase. > > As Mandy suggested, I create this PR for changes involvin

Withdrawn: JDK-8267936: PreserveAllAnnotations option isn't tested

2021-08-24 Thread duke
On Tue, 1 Jun 2021 09:30:40 GMT, Jaroslav Tulach wrote: > There doesn't seem to be much support for the complete changes in #4245. To > get at least something useful from that endeavor I have extracted the test > for existing behavior of `-XX:+PreserveAllAnnotations` and I am offering it > in

Withdrawn: 8268250: Class.arrayType() for a 255-d array throws undocumented IllegalArgumentException

2021-08-02 Thread duke
On Mon, 7 Jun 2021 00:09:33 GMT, Joe Darcy wrote: > Make explicit illegal argument cases of Class.arrayType. > > Please also review the corresponding CSR: > https://bugs.openjdk.java.net/browse/JDK-8268300 This pull request has been closed without being integrated. - PR: https://

Withdrawn: 8266936: Add a finalization JFR event

2021-07-14 Thread duke
On Tue, 18 May 2021 20:55:10 GMT, Brent Christian wrote: > Please review this enhancement to add a new JFR event, generated whenever a > finalizer is run. > (The makeup is similar to the Deserialization event, > [JDK-8261160](https://bugs.openjdk.java.net/browse/JDK-8261160).) > > The event's

Withdrawn: 8266578: Disambiguate BigDecimal description of scale

2021-07-06 Thread duke
On Fri, 9 Oct 2020 16:14:59 GMT, Ignasi Marimon-Clos wrote: > The API Docs for `BigDecimal` introduce the meaning of `scale`. The current > writeup can be missleading when presenting the meaning of a `scale` value > that's negative. Hopefully, with this PR, the sentence is more clear. > > The

Withdrawn: 8266013: Unexpected replacement character handling on stateful CharsetEncoder

2021-07-06 Thread duke
On Tue, 27 Apr 2021 16:49:08 GMT, Ichiroh Takiguchi wrote: > When an invalid character is converted by getBytes() method, the character is > converted to replacement byte data. > Shift code (SO/SI) may not be added into right place by EBCDIC Mix charset. > EBCDIC Mix charset encoder is stateful

Withdrawn: 8173970: jar tool should have a way to extract to a directory

2021-06-24 Thread duke
On Fri, 26 Feb 2021 17:03:11 GMT, Jaikiran Pai wrote: > Can I please get a review for this patch which proposes to implement the > enhancement request noted in https://bugs.openjdk.java.net/browse/JDK-8173970? > > The commit in this PR introduces the `-o` and `--output-dir` option to the > `ja

Withdrawn: 8200559: Java agents doing instrumentation need a means to define auxiliary classes

2021-06-18 Thread duke
On Fri, 16 Apr 2021 13:44:16 GMT, Rafael Winterhalter wrote: > To allow agents the definition of auxiliary classes, an API is needed to > allow this. Currently, this is often achieved by using `sun.misc.Unsafe` or > `jdk.internal.misc.Unsafe` ever since the `defineClass` method was removed >

Withdrawn: 8199594: Add doc describing how (?x) ignores spaces in character classes

2021-06-17 Thread duke
On Mon, 19 Apr 2021 20:43:26 GMT, Ian Graves wrote: > Clarifying note on comments mode to explicitly note that whitespace within > character classes is ignored. This pull request has been closed without being integrated. - PR: https://git.openjdk.java.net/jdk/pull/3577

Withdrawn: 8265039: Adjust javadoc for ByteArray*Stream and InputStream

2021-06-07 Thread duke
On Mon, 5 Apr 2021 08:37:15 GMT, Сергей Цыпанов wrote: > Hello, > > to avoid cases detected in > [https://github.com/openjdk/jdk/pull/2992](https://github.com/openjdk/jdk/pull/2992) > I propose to modify JavaDoc of `ByteArray*Stream` to explicitly mention > redundancy of wrapping with `Buff

Withdrawn: 8264896: Remove redundant '& 0xFF' from int-to-byte cast

2021-06-03 Thread duke
On Thu, 4 Mar 2021 12:16:29 GMT, Сергей Цыпанов wrote: > When we do > > byte b1 = (byte) (value & 0xFF); > > we keep from int only 1 lower byte and exactly the same can be achieved with > plain cast. See the test below: > > public class Main { > public static void main(String[] args) throw

Withdrawn: JDK-8266254: Update to use jtreg 6

2021-06-02 Thread duke
On Wed, 2 Jun 2021 16:13:48 GMT, Jonathan Gibbons wrote: > Please review the change to update to using jtreg 6. > > The primary change is to the jib-profiles.js file, which specifies the > version of jtreg to use, for those systems that rely on this file. In > addition, the `requiredVersion`

Withdrawn: 8258588: MD5 MessageDigest in java.util.UUID should be cached

2021-05-19 Thread duke
On Thu, 17 Dec 2020 13:36:17 GMT, PROgrm_JARvis wrote: > Please review this change moving lookup of MD5 digest in `java.lang.UUID` to > an internal holder class. This pull request has been closed without being integrated. - PR: https://git.openjdk.java.net/jdk/pull/1821

Withdrawn: 8260710: Inline and simplify String*::{coder, value, isLatin1} methods

2021-05-19 Thread duke
On Mon, 1 Feb 2021 13:11:52 GMT, Aleksey Shipilev wrote: > Since Compact Strings implementation, there are simple methods in String and > StringBuilders: `coder()`, `value()`, `isLatin1()`. They are mostly there to > capture `COMPACT_STRINGS` flag that would fold to "false" when compact > stri

Withdrawn: 8257733: Move module-specific data from make to respective module

2021-04-21 Thread duke
On Thu, 3 Dec 2020 23:44:20 GMT, Magnus Ihse Bursie wrote: > A lot (but not all) of the data in make/data is tied to a specific module. > For instance, the publicsuffixlist is used by java.base, and fontconfig by > java.desktop. (A few directories, like mainmanifest, is *actually* used by > ma

Withdrawn: 8013527: calling MethodHandles.lookup on itself leads to errors

2021-04-21 Thread duke
On Wed, 3 Feb 2021 01:50:36 GMT, Mandy Chung wrote: > JDK-8013527: calling MethodHandles.lookup on itself leads to errors > JDK-8257874: MethodHandle injected invoker doesn't have necessary private > access > > Johannes Kuhn is also a contributor to this patch. > > A caller-sensitive method ca