Re: Proposal for adding O_DIRECT support into JDK 9

2016-10-13 Thread ecki
The question is, if support for fadvice() would be more flexible (and somewhat saner). And of course real async fio .) Gruss Bernd -- http://bernd.eckenfels.net Von: Alan Burlison Gesendet: Donnerstag, 13. Oktober 2016 14:30 An: Brian Burkhalter; Lu, Yingqi Cc: nio-...@openjdk.java.net; Kaczma

Re: Reg - Sub Process creation from java takes more time

2016-09-15 Thread ecki
Hello, Does the (virtual) size increase over time when it gets slower? How does the GC log looks like, any increasing activity or longer pauses? If you let this VM run for longer time (when it slows down), will it eventually fail because of some resource exhaustion? How often does the execute

Re: Reg - Sub Process creation from java takes more time

2016-09-15 Thread ecki
Hello, Do you monitor heap usage and virtual memory size of your Java process? I would look out for increase (which causes slower for tines). Also it is generally a good idea to turn on GC logging and look into it if a java process degregades over time Gruss Bernd Just BTW: I think Java would

Re: RFR 8159126 Add test to validate DriverManager.println output whenDriverManager is initially loaded

2016-09-12 Thread ecki
Hello, It looks like the test passes when the IOException happens (skips assert). Besides, what about actually providing a well known driver (only?). Then you dont have to depend on the debug output. Gruss Bernd -- http://bernd.eckenfels.net >From Win 10 Mobile Von: Lance Andersen

AW: Executors enhancement

2016-08-09 Thread ecki
This is nice in theory but has a number of drawbacks. First of all the common pool is not very easy to configure. It takes the available CPUs and if you run more than one VM you overcommit. Secondly different strategies to deal with longrunning or blocked jobs, with priority inheritance, with fi

AW: java.io.Writer uses CharSequence.toString()

2016-07-29 Thread ecki
Hello, Have to agree with Fabian handling CharSequences (and special case StringBuilder) is pretty weak, in CharBuffer.append(CharSequence) you see the same toString. I would expect it to do: - Instamceof String -> use it - Instance of StringBuilder -> extract char[] and iterate - Instance of Ch

AW: Files.read/readAllBytes can loop once with zero size buffer

2016-07-28 Thread ecki
Hello, It could always read with a initial buffer of 0.5-16k and return a truncated copy if it read less (and a omit truncation by returning shared static 0 length array if empty). But this will only optimize the 0 byte case. Gruss Bernd -- http://bernd.eckenfels.net >From Win 10 Mobile Von:

RE: Files.walk() is unusable because of AccessDeniedException

2016-05-24 Thread ecki
The AccessDeniedExceptions are not a java security mechanism. It is a OS mechanism and i think it is good that java reveals all information also available with native access (i.e. if you have no 'x' permission on a dir you cannot enter it but you can see it (as long asmyou have read permission o

Re: Memory leak in com.sun.jndi.ldap.pool.PoolCleaner

2016-05-12 Thread ecki
Hello, Should this also care about overwriting threadlocals, threadgroup, securitycontext and default exception handler (i.e. using the new constructor for managed threads and some). Gruss Bernd -- http://bernd.eckenfels.net -Original Message- From: Mark Thomas To: Alan Bateman , c

Re: RFR(m): 8140281 deprecate Optional.get()

2016-04-27 Thread ecki
Hello, I agree, using the isPresent()/get() is fine, especially for code which interfaces between Optional-using APIs and null/default using APIs. Especially if you do not want/should use streams or lambda. And as I recall the "do not use Optional everywhere" motto is repeatet from Oracle as we

Re: RFR [9 ] 8149656: Examine usages of sun.misc.LRUCache

2016-02-12 Thread ecki
Since it is only implemented with one anonymous class you could also think about making it a concrete PatternLRUCache -- http://bernd.eckenfels.net -Original Message- From: Chris Hegarty To: Core-Libs-Dev Sent: Fr., 12 Feb. 2016 16:55 Subject: RFR [9 ] 8149656: Examine usages of sun.

Re: JDK RFR of 8147545: Remove sun.misc.ManagedLocalsThread from java.prefs

2016-01-22 Thread ecki
Hello, I would name it more like "Preference Timer Shutdown Hook" and "Preference Dispatch Thread" and "Preference Flush Thread" (i.e. include the subsystem) + new Thread(null, null, "Sync Timer Thread", 0, false) Gruss Bernd -- http://bernd.eckenfels.net -Original Message- From: Ch

[rmi] supressStackTraces does not suppress suppressed exception

2015-12-08 Thread ecki
Hello I noticed that RMI servers honor the sun.rmi.server.suppressStackTraces system property only for the `cause` member, but not for the suppressed exception array. This seems to be not documented (and is most likely not wanted?) It looks like it does also not handle SQLWarning#getNextWarning

Re: RFR [9] 8056152 API to create Threads that do not inherit InheritableThreadLocals

2015-12-08 Thread ecki
Hm, In need of an API I would stick to an executor. Maybe (but thats likely not needed) have a common (caching) thread pool for such tasks. I would kt encourage using those stray thread classes. Gruss Bernd -- http://bernd.eckenfels.net -Original Message- From: Mandy Chung To: Roge

Re: [bug] sun.nio.ch.PipeImpl uses IPv4

2015-12-03 Thread ecki
I think this is somewhat intentional: potential broken localhost resolve or resolve of 127.0.0.1 vs. ::1 are just a bunch of causes for problems (and delays) which are all avoided by hardcoding the address family and address. However it causes now problems when systems are migrating to v6only.

Re: RFR:JDK-8071919 :Add java.time.Clock.tickMillis(ZoneId zone) method

2015-11-13 Thread ecki
Hello, I find the name rather confusing. I was wondering something like "is this returning millis-ticks based on a different timezone". Something like "toMillisPrecisionClock" sounds better to me (but I might have the terminology wrong). Gruss Bernd -- http://bernd.eckenfels.net -Origin

Re: RFR [9] 8139706: JarFile.getBytes could use InputStream.readNBytes

2015-10-15 Thread ecki
Hello, This does change a bit the semantic of the length check. If the stream would return more bytes than the zipentry says the new version would ignore them, the old version was consuming then and then fail the check. However I am not sure if this is relevant. Gruss Bernd -- http://bernd.

Modifier order for 'default' (was: RFR: 8136583: Core libraries should use blessed modifier order)

2015-09-15 Thread ecki
Martin, this will be known as the "blame martin" patch, good work. But more seriously a minor thing I noticed in your shell script (as well as the mentioned sources and some coding guidelines), the new interface `default` method modifier is not defined in any of those lists. Not sure if it is a