Re: RFR: 8284638: store skip buffers in InputStream Object [v7]

2022-04-19 Thread jmehrens
On Tue, 19 Apr 2022 18:04:03 GMT, XenoAmess wrote: > no, we use other way, but yes for we take care of thread safety. Fair enough. > Don't think it necessary... I think making it cannot touched by other object > (with security manager on) is enough. I was thinking more for heapdumps due to ex

Re: RFR: 8284638: store skip buffers in InputStream Object [v7]

2022-04-18 Thread jmehrens
On Fri, 15 Apr 2022 18:56:37 GMT, XenoAmess wrote: >> @jmehrens what about this then? >> I think it safe now(actually this mechanism is learned from Reader) > > XenoAmess has updated the pull request incrementally with one additional > commit since the last revision: &

Re: RFR: 8279598: Provide adapter from RandomGenerator to Random [v19]

2022-03-18 Thread jmehrens
On Fri, 18 Mar 2022 13:10:10 GMT, liach wrote: >you are not expected to inspect a random object by its string. ToString representations tend to show up in exception messages and logging. Seems like this adapter just won't adapt that call. Not a deal breaker. > Also the reverse order comparat

Re: RFR: 8279598: Provide adapter from RandomGenerator to Random [v19]

2022-03-18 Thread jmehrens
On Fri, 18 Mar 2022 00:24:56 GMT, Yasser Bazzi wrote: > The toString method of both classes do not implement anything so i dont think > we should override it, The inherited implementation is descriptive enough because the the class names are the implementation: https://github.com/openjdk/

Re: RFR: 8279598: Provide adapter from RandomGenerator to Random [v19]

2022-03-17 Thread jmehrens
On Wed, 16 Mar 2022 14:54:41 GMT, Yasser Bazzi wrote: >> Hi, could i get a review on this implementation proposed by Stuart Marks, i >> decided to use the >> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html >> interface to create the default me

Re: RFR: 8193682: Infinite loop in ZipOutputStream.close() [v3]

2021-10-12 Thread jmehrens
On Tue, 12 Oct 2021 13:28:21 GMT, Ravi Reddy wrote: >> Hi all, >> >> Please review this fix for Infinite loop in ZipOutputStream.close(). >> The main issue here is when ever there is an exception during close >> operations on GZip we are not setting the deflator to a finished state which >> is

Re: RFR: 8264148: Update spec for exceptions retrofitted for exception chaining

2021-03-30 Thread jmehrens
On Wed, 24 Mar 2021 23:17:46 GMT, Joe Darcy wrote: > 8264148: Update spec for exceptions retrofitted for exception chaining src/java.base/share/classes/java/io/WriteAbortedException.java line 86: > 84: @Override > 85: public Throwable getCause() { > 86: return detail; Use Suppr

Re: RFR: 8264148: Update spec for exceptions retrofitted for exception chaining

2021-03-29 Thread jmehrens
On Thu, 25 Mar 2021 18:52:54 GMT, Stuart Marks wrote: > One special case is the **public field** in `WriteAbortedException`. This is > really bad and something ought to be done about this, including deprecation, > and maybe more. This implies that the exception is mutable, right? Hrrmph. > Isn

Re: RFR: 8254979: Class.getSimpleName() returns non-empty for lambda and method

2021-03-17 Thread jmehrens
On Tue, 16 Mar 2021 22:24:55 GMT, Joe Darcy wrote: > java.lang.Class has a number of methods to return some kind of textual token > associated with the class, including a type name, canonical name, simple > name, and separately the results of toString(). > > Bug 8254979 notes that getSimpleNam

Re: RFR: 6323374: (coll) Optimize Collections.unmodifiable* and synchronized* [v3]

2021-02-18 Thread jmehrens
On Wed, 17 Feb 2021 19:12:19 GMT, Ian Graves wrote: >> This raises some interesting issues and makes me wonder if we should allow a >> single-wrap of the `ImmutableCollections` classes for now to make this less >> onerous. > > Yes -- I think in response to this it makes more sense to pull the