Re: RFR: 8180352: Add Stream.toList() method [v3]

2020-11-23 Thread sergus13
On Sat, 21 Nov 2020 11:22:55 GMT, RĂ©mi Forax wrote: >> `listFromTrustedArrayNullsAllowed` is clearly not an option, as it will >> produce shared-secret leaking (see >> [JDK-8254090](https://bugs.openjdk.java.net/browse/JDK-8254090) for a >> similar case). StreamEx solution is dirty as it

Re: RFR: 8246739: InputStream.skipNBytes could be implemented more efficiently [v2]

2020-11-20 Thread sergus13
On Thu, 19 Nov 2020 20:20:17 GMT, Brian Burkhalter wrote: >> Please review this modification of `java.io.InputStream.skipNBytes(long)` to >> improve its performance when `skip(long)` skips fewer than the requested >> number of bytes. In the current implementation, `skip(long)` is invoked once

Re: RFR: 8246739: InputStream.skipNBytes could be implemented more efficiently [v2]

2020-11-20 Thread sergus13
On Thu, 19 Nov 2020 20:20:17 GMT, Brian Burkhalter wrote: >> Please review this modification of `java.io.InputStream.skipNBytes(long)` to >> improve its performance when `skip(long)` skips fewer than the requested >> number of bytes. In the current implementation, `skip(long)` is invoked once

Re: RFR: 8246739: InputStream.skipNBytes could be implemented more efficiently [v2]

2020-11-20 Thread sergus13
On Fri, 20 Nov 2020 09:56:16 GMT, sergus13 wrote: >> Brian Burkhalter has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - 8246739: InputStream.skipNBytes could be implemented more efficiently >> - 8246739