RFR 8144931: Assert class signatures are correct and refer to valid classes

2016-02-17 Thread shilpi rastogi
Hi All, Please review fix for the following bug- https://bugs.openjdk.java.net/browse/JDK-8144931 http://cr.openjdk.java.net/~srastogi/8144931/webrev.01/ Thanks, Shilpi

Re: RFR: 8071368 Use more concrete types for NamedFunction constants in the code

2016-02-09 Thread shilpi rastogi
y the runtime compiler. By removing them from the Java code it might slightly improve C2 compilation time. Approval from Vladimir/John would be good. Paul. On 4 Feb 2016, at 13:16, shilpi rastogi wrote: Hi All, Please review the following- https://bugs.openjdk.java.net/browse/JDK

Re: RFR 8138884:MethodHandles.Lookup.findVirtual() Javadoc fails to consider private interface methods

2016-02-09 Thread shilpi rastogi
Hi All, Please review my updated patch http://cr.openjdk.java.net/~srastogi/8138884/webrev.01/ Same is not applicable for "Lookup.unreflect()". Thanks, Shilpi Hi All, Please review my fix related to java doc. MethodHandles.Lookup.findVirtual() Javadoc fails to consider private methods of a

Re: RFR: 8071368 Use more concrete types for NamedFunction constants in the code

2016-02-08 Thread shilpi rastogi
y the runtime compiler. By removing them from the Java code it might slightly improve C2 compilation time. Approval from Vladimir/John would be good. Paul. On 4 Feb 2016, at 13:16, shilpi rastogi wrote: Hi All, Please review the following- https://bugs.openjdk.java.net/browse/JDK

Re: RFR 8138578:MethodHandles.Lookup.findSpecial() Javadoc fails to consider static methods

2016-02-08 Thread shilpi rastogi
Gentle Reminder! On 2/5/2016 6:48 PM, Paul Sandoz wrote: On 29 Jan 2016, at 12:43, shilpi rastogi wrote: Hi All, Please review the updated patch- http://cr.openjdk.java.net/~srastogi/8138578/webrev.01/ I verified Lookup.unreflectSpecial() also throws java.lang.IllegalAccessException so

Re: RFR 8138578:MethodHandles.Lookup.findSpecial() Javadoc fails to consider static methods

2016-02-04 Thread shilpi rastogi
Gentle reminder! On 1/29/2016 6:13 PM, shilpi rastogi wrote: Hi All, Please review the updated patch- http://cr.openjdk.java.net/~srastogi/8138578/webrev.01/ I verified Lookup.unreflectSpecial() also throws java.lang.IllegalAccessException so updated the JavaDoc. Thanks, Shilpi

RFR: 8071368 Use more concrete types for NamedFunction constants in the code

2016-02-04 Thread shilpi rastogi
Hi All, Please review the following- https://bugs.openjdk.java.net/browse/JDK-8071368 http://cr.openjdk.java.net/~srastogi/8071368/webrev.02/ Thanks, Shilpi

Re: RFR 8138578:MethodHandles.Lookup.findSpecial() Javadoc fails to consider static methods

2016-01-29 Thread shilpi rastogi
“or” statements with a comma would help readability in the JavaDoc (same applies to the the patch for findVirtual). Paul. > On 22 Jan 2016, at 10:22, shilpi rastogi wrote: > > > Gentle Reminder! > > Original Message > Subject: [9u-dev] 8138578:MethodHandl

Fwd: RFR 8138578:MethodHandles.Lookup.findSpecial() Javadoc fails to consider static methods

2016-01-22 Thread shilpi rastogi
Gentle Reminder! Original Message Subject: [9u-dev] 8138578:MethodHandles.Lookup.findSpecial() Javadoc fails to consider static methods Date: Wed, 20 Jan 2016 18:12:30 +0530 From: shilpi rastogi Organization: Oracle Corporation To: core-libs-dev@openjdk.java.net

RFR 8138884:MethodHandles.Lookup.findVirtual() Javadoc fails to consider private interface methods

2016-01-22 Thread shilpi rastogi
Gentle Reminder! Original Message Subject: [9u-dev] 8138884:MethodHandles.Lookup.findVirtual() Javadoc fails to consider private interface methods Date: Wed, 20 Jan 2016 18:12:24 +0530 From: shilpi rastogi Organization: Oracle Corporation To: core-libs-dev

[9u-dev] 8138578:MethodHandles.Lookup.findSpecial() Javadoc fails to consider static methods

2016-01-20 Thread shilpi rastogi
Hi All, Please review my fix related to java doc. MethodHandles.Lookup.findSpecial() Javadoc fails to consider static methods- MethodHandles.Lookup.findSpecial() throws IllegalAccessException if the target method is static. Bug link- https://bugs.openjdk.java.net/browse/JDK-8138578

[9u-dev] 8138884:MethodHandles.Lookup.findVirtual() Javadoc fails to consider private interface methods

2016-01-20 Thread shilpi rastogi
Hi All, Please review my fix related to java doc. MethodHandles.Lookup.findVirtual() Javadoc fails to consider private methods of an interface. MethodHandles.Lookup.findVirtual() throws IllegalAccessException if the method MH is being created for is private and declared in an interface. Bu