Nice cleanup, Claes! Reviewed.
Best regards,
Vladimir Ivanov
On 2/20/17 5:24 PM, Claes Redestad wrote:
Hi,
the LambdaForm.debugName field is useful for debugging, but names
are generated and retained in this field also for production code, which
is then used to name generated methods and class
On 2017-02-22 07:20, John Rose wrote:
On Feb 20, 2017, at 6:24 AM, Claes Redestad wrote:
the LambdaForm.debugName field is useful for debugging, but names
are generated and retained in this field also for production code, which
is then used to name generated methods and classes.
Reviewed.
On Feb 20, 2017, at 6:24 AM, Claes Redestad wrote:
>
> the LambdaForm.debugName field is useful for debugging, but names
> are generated and retained in this field also for production code, which
> is then used to name generated methods and classes.
Reviewed. This is a good change; thank you.
> On 21 Feb 2017, at 16:19, Claes Redestad wrote:
>>
>> LambdaForm
>> —
>>
>> You might wanna consider colocating "lambdaName” with “generateDebugName”,
>> then it’s easier to see that the latter is called from within a synchronized
>> block of the former.
>>
>
> yes, updated in-place.
>
Hi Paul,
On 2017-02-21 23:46, Paul Sandoz wrote:
On 20 Feb 2017, at 06:24, Claes Redestad wrote:
Hi,
the LambdaForm.debugName field is useful for debugging, but names
are generated and retained in this field also for production code, which
is then used to name generated methods and classes.
> On 20 Feb 2017, at 06:24, Claes Redestad wrote:
>
> Hi,
>
> the LambdaForm.debugName field is useful for debugging, but names
> are generated and retained in this field also for production code, which
> is then used to name generated methods and classes.
>
> This patch suggests to extract th
Hi,
the LambdaForm.debugName field is useful for debugging, but names
are generated and retained in this field also for production code, which
is then used to name generated methods and classes.
This patch suggests to extract this field and make the debug name an
external mapping that is only ge
