Thank you Roger and Jon for the comments!
Change request withdrawn :-)
Thanks,
Amy
On 10/14/17 3:04 AM, Roger Riggs wrote:
Hi Amy,
I don't see a problem with the cases of 'Total tests run: 0'. It is
very explicit, no tests were selected.
Testng has a number of dynamic mechanisms for test s
Hi Amy,
I don't see a problem with the cases of 'Total tests run: 0'. It is
very explicit, no tests were selected.
Testng has a number of dynamic mechanisms for test selection such that
even files in the test directories might not have any tests to run. As
Jon pointed out that's just part of
FWIW, this is a side-effect of taking jtreg having to take some corner
cases into account when determining what are "jtreg" tests in a
hierarchy of TestNG tests.
The underlying problem is that there is no easy reliable way to
determine if a source file contains test cases or if it is just a
l
non-test be run as a test, the result may lead to confusion.
For example, if look at MockSimplePeriod.java test result, it shows:
===
java/time/test/java/time/MockSimplePeriod.java
Total tests run: 0, Failures: 0, Skips: 0
==
Hi Amy,
I'm not convinced this is the right move. Moving parts of tests further
from the test
is not helpful from a maintenance point of view.
I'm not concerned about compilation time. Its not significant.
For example, AbstractDateTimeTest has @Test directives and is not just
library code.
Please review the patch to change TestNG.dirs and lib.dirs (def and file
structure) for test/jdk/java/time.
test/jdk/java/time contains three sets of tests:
nontestng/
tck/
test/
Tests from directory "tck" and "test" are testng tests with properties:
TestNG.dirs = ..
lib.dirs = ../../../lib/tes
