+1
On 4/23/18, 6:25 PM, Naoto Sato wrote:
Hi Sherman, thanks for the review.
On 4/23/18 1:06 PM, Xueming Shen wrote:
Naoto,
Here some comments
(1) CLDRTimeZoneNameProviderImpl.java:
Ln#58: to use Stream.toArray(String[]::new) ? no sure which
one is faster
Ln#155-160:
I had a quick look through and didn't see anything obvious, but its
not an area I know well.
Stephen
On 17 April 2018 at 22:28, Naoto Sato wrote:
> Hello,
>
> Please review the changes to the following issue:
>
> https://bugs.openjdk.java.net/browse/JDK-8181157
>
> The proposed fix is located at
Hi Sherman, thanks for the review.
On 4/23/18 1:06 PM, Xueming Shen wrote:
Naoto,
Here some comments
(1) CLDRTimeZoneNameProviderImpl.java:
Ln#58: to use Stream.toArray(String[]::new) ? no sure which one
is faster
Ln#155-160:
is it worth considering to check all possi
Naoto,
Here some comments
(1) CLDRTimeZoneNameProviderImpl.java:
Ln#58: to use Stream.toArray(String[]::new) ? no sure which one is faster
Ln#155-160:
is it worth considering to check all possible empty slots in "names"
here
(from index_std_long to index_std_short?
Hello,
Please review the changes to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8181157
The proposed fix is located at:
http://cr.openjdk.java.net/~naoto/8181157/webrev.05/
This RFE is to implement CLDR time zone names fallback mechanism [1].
Prior to this fix, time zone na
