Re: [11] RFR: 8206445: JImageListTest.java failed in Windows

2018-07-23 Thread Alan Bateman
On 23/07/2018 16:02, vyom tewari wrote: Hi Srinivas, If runTests() throws exception then  "System.gc()" will not  be invoked. which probably doesn't matter because the test will fail anyway (this issue is about jtreg doing cleanup when the test passes). -Alan

Re: [11] RFR: 8206445: JImageListTest.java failed in Windows

2018-07-23 Thread vyom tewari
30 Chennai, Kolkata, Mumbai, New Delhi Subject: Re: [11] RFR: 8206445: JImageListTest.java failed in Windows On 09/07/2018 11:38, Srinivas Dama wrote: Hi, Please review webrev: http://cr.openjdk.java.net/~sdama/8206445/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8206445 testListEmpty

Re: [11] RFR: 8206445: JImageListTest.java failed in Windows

2018-07-23 Thread Srinivas Dama
: alan.bate...@oracle.com To: srinivas.d...@oracle.com, core-libs-dev@openjdk.java.net Sent: Monday, 9 July, 2018 4:23:48 PM GMT +05:30 Chennai, Kolkata, Mumbai, New Delhi Subject: Re: [11] RFR: 8206445: JImageListTest.java failed in Windows On 09/07/2018 11:38, Srinivas Dama wrote: > Hi, > &g

Re: [11] RFR: 8206445: JImageListTest.java failed in Windows

2018-07-09 Thread Alan Bateman
On 09/07/2018 11:38, Srinivas Dama wrote: Hi, Please review webrev: http://cr.openjdk.java.net/~sdama/8206445/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8206445 testListEmptyFile looks okay but you can reduce the code if if you use Path.of("."). testListNotAnImage can use Path.of

[11] RFR: 8206445: JImageListTest.java failed in Windows

2018-07-09 Thread Srinivas Dama
Hi, Please review webrev: http://cr.openjdk.java.net/~sdama/8206445/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8206445 Regards, Srinivas