Re: [12] RFR: 8216176: Clarify the singleton description in j.t.c.JapaneseEra class

2019-01-08 Thread Rachna Goel
Looks good to me. On 1/8/19 11:16 PM, Naoto Sato wrote: Hello, Please review the change for the following issue: Issue: https://bugs.openjdk.java.net/browse/JDK-8216176 CSR: https://bugs.openjdk.java.net/browse/JDK-8216177 The proposed changeset is located at: http://cr.openjdk.java.net/~nao

Re: [12] RFR: 8216176: Clarify the singleton description in j.t.c.JapaneseEra class

2019-01-08 Thread Roger Riggs
Hi Naoto, Looks fine. Roger On 01/08/2019 12:46 PM, Naoto Sato wrote: Hello, Please review the change for the following issue: Issue: https://bugs.openjdk.java.net/browse/JDK-8216176 CSR: https://bugs.openjdk.java.net/browse/JDK-8216177 The proposed changeset is located at: http://cr.openj

[12] RFR: 8216176: Clarify the singleton description in j.t.c.JapaneseEra class

2019-01-08 Thread Naoto Sato
Hello, Please review the change for the following issue: Issue: https://bugs.openjdk.java.net/browse/JDK-8216176 CSR: https://bugs.openjdk.java.net/browse/JDK-8216177 The proposed changeset is located at: http://cr.openjdk.java.net/~naoto/8216176/webrev.00/ This is a simple one line change th