Hi,
A release note would be a good idea to explain the change in behavior of
SMART mode,
I added label "release-note=yes"
Regards, Roger
On 05/30/2019 09:50 AM, Roger Riggs wrote:
Hi,
The behavior is within the spec and seems more just like a bug in the
implementation.
Also, an exception
Thanks, Roger.
On 5/30/19 6:55 AM, Roger Riggs wrote:
Hi Naoto,
This looks ok.
Typically, it is not necessary to check the exception message text.
I just wanted to make sure that the thrown DateTimeParseException is
none other than the exception that is expected. There seems no other way
Hi Naoto,
This looks ok.
Typically, it is not necessary to check the exception message text.
Thanks, Roger
On 05/29/2019 05:21 PM, Lance Andersen wrote:
Hi Naoto,
This is OK.
Could you please add an @summary as it is missing so that we are consistent
with other tests.
No need to spin a
Hi,
The behavior is within the spec and seems more just like a bug in the
implementation.
Also, an exception was thrown but it was for the wrong reason.
$.02, Roger
On 05/29/2019 06:55 PM, naoto.s...@oracle.com wrote:
Hi Joe,
Right, I will file a corresponding CSR.
Naoto
On 5/29/19 3:51
+1
On Wed, 29 May 2019, 22:13 , wrote:
> Hi,
>
> Please review the fix for the following issue:
>
> https://bugs.openjdk.java.net/browse/JDK-8223773
>
> The proposed changeset is located at:
>
> https://cr.openjdk.java.net/~naoto/8223773/webrev.00/
>
> Checking the range of HourOfAmPm with the
Hi Joe,
Right, I will file a corresponding CSR.
Naoto
On 5/29/19 3:51 PM, Joseph D. Darcy wrote:
Hi Naoto,
Should this bug get a CSR for the behavioral change?
Cheers,
-Joe
On 5/29/2019 2:12 PM, naoto.s...@oracle.com wrote:
Hi,
Please review the fix for the following issue:
Hi Naoto,
Should this bug get a CSR for the behavioral change?
Cheers,
-Joe
On 5/29/2019 2:12 PM, naoto.s...@oracle.com wrote:
Hi,
Please review the fix for the following issue:
https://bugs.openjdk.java.net/browse/JDK-8223773
The proposed changeset is located at:
Thanks, Lance.
Sure, will update the test case with @summary.
Naoto
On 5/29/19 2:21 PM, Lance Andersen wrote:
Hi Naoto,
This is OK.
Could you please add an @summary as it is missing so that we are
consistent with other tests.
No need to spin a webrev again though
Best
Lance
On May 29,
Hi Naoto,
This is OK.
Could you please add an @summary as it is missing so that we are consistent
with other tests.
No need to spin a webrev again though
Best
Lance
> On May 29, 2019, at 5:12 PM, naoto.s...@oracle.com wrote:
>
> Hi,
>
> Please review the fix for the following issue:
>
>
Hi,
Please review the fix for the following issue:
https://bugs.openjdk.java.net/browse/JDK-8223773
The proposed changeset is located at:
https://cr.openjdk.java.net/~naoto/8223773/webrev.00/
Checking the range of HourOfAmPm with the range of AmPmOfDay is
apparently incorrect. Fixing it
10 matches
Mail list logo
