+1, looks good!
Best regards,
Joe
On 12/5/19 12:13 PM, Roger Riggs wrote:
Hi Naoto,
Thanks for the updates.
Looks fine.
Roger
On 12/5/19 1:49 PM, naoto.s...@oracle.com wrote:
Thanks, Joe and Roger, for the reviews. Here is the updated webrev:
Hi Naoto,
Thanks for the updates.
Looks fine.
Roger
On 12/5/19 1:49 PM, naoto.s...@oracle.com wrote:
Thanks, Joe and Roger, for the reviews. Here is the updated webrev:
http://cr.openjdk.java.net/~naoto/8222756/webrev.02/
These are the changes since v.01:
CompactNumberFormat.java:
-
Thanks, Joe and Roger, for the reviews. Here is the updated webrev:
http://cr.openjdk.java.net/~naoto/8222756/webrev.02/
These are the changes since v.01:
CompactNumberFormat.java:
- Reflected the CSR changes (thank you, JoeD, for the quick
turnaround!), and misc typos in the spec.
- Added
Hi Naoto,
Looks very good, and a few comments...
CompactNumberFormat.java:
144: "each singular and plural patterns" -> "each singular and plural
pattern"
148: "Should the pattern include" -> "If the pattern includes"
336: Add a "." at the end of the sentence
407/417: If the plural
Hi Naoto,
Looks good. I understand you'll update the webrev (with the added
statement to readObject) once the CSR is approved.
ResourceBundleGenerator.java might have been accidentally touched as
there's no change there.
I wonder if you need to guard the pluralRules input since you're
I modified CompactNumberFormat.java to simplify the syntax parsing:
https://cr.openjdk.java.net/~naoto/8222756/webrev.01/
Please review this webrev instead.
Naoto
On 11/25/19 1:16 PM, naoto.s...@oracle.com wrote:
Hello,
CompactNumberFormat has been added since JDK 12 to support compact
Hello,
CompactNumberFormat has been added since JDK 12 to support compact
number formatting, such as 10_000 being formatted as "10K." [1] It works
fine for English, however, not for other languages that take plural
forms in formatted number prefixes/suffixes. In order to fix this, I
filed
