Re: [15] RFR(T) : 8249697 : java/lang/invoke/RicochetTest.java should use @requires instead of @ignore

2020-07-20 Thread Mandy Chung
webrev.03 looks good. Mandy On 7/20/20 12:22 PM, Igor Ignatyev wrote: Hi Mandy, you are right, it's better to have just one @run, and as I don't think that 7197210 changes '-XX:-VerifyDependencies' nor '/timeout=3600' are needed anymore, I suggest to restore the test to its original version

Re: [15] RFR(T) : 8249697 : java/lang/invoke/RicochetTest.java should use @requires instead of @ignore

2020-07-20 Thread Igor Ignatyev
Hi Mandy, you are right, it's better to have just one @run, and as I don't think that 7197210 changes '-XX:-VerifyDependencies' nor '/timeout=3600' are needed anymore, I suggest to restore the test to its original version w/ `@run junit/othervm -DRicochetTest.MAX_ARITY=255

Re: [15] RFR(T) : 8249697 : java/lang/invoke/RicochetTest.java should use @requires instead of @ignore

2020-07-20 Thread Mandy Chung
Hi Igor, OK.  Should this revert the change by 7049122 then? i.e. simply change -DRicochetTest.MAX_ARITY=10 to 255 Your proposed patch adds a new @run instead of modifying the existing @run command:   * @run junit/othervm/timeout=3600 -XX:+IgnoreUnrecognizedVMOptions

Re: [15] RFR(T) : 8249697 : java/lang/invoke/RicochetTest.java should use @requires instead of @ignore

2020-07-20 Thread Igor Ignatyev
Hi Mandy, that's actually the opposite, the 2nd subtest is run only in modes other than Xcomp, as w/ Xcomp the test creates lots of adapters and used to lead to JVM failure as described in 7049122. I tried to reproduce this failure, but in vain,.. after a bit more historical digging, I

Re: [15] RFR(T) : 8249697 : java/lang/invoke/RicochetTest.java should use @requires instead of @ignore

2020-07-18 Thread Mandy Chung
On 7/17/20 8:54 PM, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev/8249697/webrev.00/ I suggest to change this:   32  * @comment The following test creates an unreasonable number of adapters in -Xcomp mode (7049122) To:    @bug 8249697    @summary verify very high number of

[15] RFR(T) : 8249697 : java/lang/invoke/RicochetTest.java should use @requires instead of @ignore

2020-07-17 Thread Igor Ignatyev
http://cr.openjdk.java.net/~iignatyev/8249697/webrev.00/ > 7 lines changed: 4 ins; 0 del; 3 mod; Hi all, could you please review this small and trivial patch for java/lang/invoke/RicochetTest.java test? from JBS: > a run of java/lang/invoke/RicochetTest.java w/ MAX_ARITY=255 was removed from