Re: [15] RFR: 8239520: ValueRange.of(long, long, long) does not throw IAE on invalid inputs

Hi Naoto, The updates look fine. Roger On 2/21/20 6:03 PM, naoto.s...@oracle.com wrote: Hi Roger, Thank you for the review. Please find my comments below. On 2/21/20 11:42 AM, Roger Riggs wrote: In the implementation ValueRange.of: 148-150; I would omit the check here since it invokes the

Re: [15] RFR: 8239520: ValueRange.of(long, long, long) does not throw IAE on invalid inputs

Hi Roger, Thank you for the review. Please find my comments below. On 2/21/20 11:42 AM, Roger Riggs wrote: In the implementation ValueRange.of: 148-150; I would omit the check here since it invokes the 4 arg form and does the same check. The difference in exception message is not worth the

Re: [15] RFR: 8239520: ValueRange.of(long, long, long) does not throw IAE on invalid inputs

Hi Naoto, The CSR looks ok. In the implementation ValueRange.of: 148-150; I would omit the check here since it invokes the 4 arg form and does the same check. The difference in exception message is not worth the extra code. Though it would help if it said that the 3 arg form is the same as

[15] RFR: 8239520: ValueRange.of(long, long, long) does not throw IAE on invalid inputs

Hi, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8239520 The proposed changeset is located at: https://cr.openjdk.java.net/~naoto/8239520/webrev.00/ This change lets 3-arg ValueRange.of() method thrown an IAE on invalid inputs, as well as corrects