Re: [7u6] RFR (JAXP) : 7157610: NullPointerException occurs when parsing XML doc

2012-06-11 Thread Lance Andersen - Oracle
Hi Joe, No need to see it with just the change of the comment removed... good to go by me :-) Best Lance On Jun 11, 2012, at 4:23 PM, Joe Wang wrote: > Thanks Lance. > > That comment was there forever, removed now :) > > New webrev: > http://cr.openjdk.java.net/~joehw/7u6/7157610/webrev/ >

Re: [7u6] RFR (JAXP) : 7157610: NullPointerException occurs when parsing XML doc

2012-06-11 Thread Joe Wang
Thanks Lance. That comment was there forever, removed now :) New webrev: http://cr.openjdk.java.net/~joehw/7u6/7157610/webrev/ -Joe On 6/11/2012 12:33 PM, Lance Andersen - Oracle wrote: Looks OK joe. Do you still need the comment

Re: [7u6] RFR (JAXP) : 7157610: NullPointerException occurs when parsing XML doc

2012-06-11 Thread Lance Andersen - Oracle
Looks OK joe. Do you still need the comment //return fSupportDTD? next() : dtdEvent; in XMLDocumentScannerImpl? If not you might consider removing it. Best Lance On Jun 11, 2012, at 3:08 PM, Joe Wang wrote: > As reported in 7157610, when > setFeature("http://apache.org/xml/features/disallo

[7u6] RFR (JAXP) : 7157610: NullPointerException occurs when parsing XML doc

2012-06-11 Thread Joe Wang
As reported in 7157610, when setFeature("http://apache.org/xml/features/disallow-doctype-decl";, true) is set on SAXParserFactory object, XMLReader object or DocumentBuilderFactory object, NullPointerException will be thrown when parsing XML document that has DOCTYPE declaration. The cause of