Re: [8u60] RFR: 8038189: Add cross-platform compact profiles support

2014-12-04 Thread Erik Joelsson
Looks good to me. /Erik On 2014-12-04 04:16, David Holmes wrote: Updated webrev: http://cr.openjdk.java.net/~dholmes/8038189/webrev.jdk.v2/ Only changes are to profile-includes.txt. Thanks, David On 2/12/2014 2:24 PM, David Holmes wrote: Erik, Many thanks for the makefile macro wizardry!

Re: [8u60] RFR: 8038189: Add cross-platform compact profiles support

2014-12-03 Thread David Holmes
Updated webrev: http://cr.openjdk.java.net/~dholmes/8038189/webrev.jdk.v2/ Only changes are to profile-includes.txt. Thanks, David On 2/12/2014 2:24 PM, David Holmes wrote: Erik, Many thanks for the makefile macro wizardry! I will incorporate, test and return with an updated webreb. David

Re: [8u60] RFR: 8038189: Add cross-platform compact profiles support

2014-12-01 Thread Alan Bateman
On 01/12/2014 00:09, David Holmes wrote: : Compact Profiles support was added in 8, but only for the Linux platform. I've now generalized this support to all the other platforms. This is an 8u only change, targetting 8u60, as soon as the jdk8u/dev starts accepting things for 8u60. Just to

Re: [8u60] RFR: 8038189: Add cross-platform compact profiles support

2014-12-01 Thread Erik Joelsson
Hello David, Most of it looks good, but profile-includes.txt could certainly benefit from some reduction in duplication. (Aside from the extension of the file itself, which I find a bit weird, but it's already there.) The two common structures that I can see are: 1. Expanding debuginfo files

Re: [8u60] RFR: 8038189: Add cross-platform compact profiles support

2014-12-01 Thread David Holmes
Erik, Many thanks for the makefile macro wizardry! I will incorporate, test and return with an updated webreb. David On 1/12/2014 7:19 PM, Erik Joelsson wrote: Hello David, Most of it looks good, but profile-includes.txt could certainly benefit from some reduction in duplication. (Aside

[8u60] RFR: 8038189: Add cross-platform compact profiles support

2014-11-30 Thread David Holmes
Main bug is 8038189 but that is a closed bug, the open backport issue is: https://bugs.openjdk.java.net/browse/JDK-8066200 Compact Profiles support was added in 8, but only for the Linux platform. I've now generalized this support to all the other platforms. This is an 8u only change,