Thank you Joe!
On 16/02/17 03:07, huizhe wang wrote:
Looks good to me.
Thanks,
Joe
On 2/15/2017 3:56 PM, Aleks Efimov wrote:
Hi Joe,
Thank you for your suggestions. New webrev can be found here:
http://cr.openjdk.java.net/~aefimov/8173390/9/01
Hi Daniel,
You're right that assertNotSame sui
Looks good to me.
Thanks,
Joe
On 2/15/2017 3:56 PM, Aleks Efimov wrote:
Hi Joe,
Thank you for your suggestions. New webrev can be found here:
http://cr.openjdk.java.net/~aefimov/8173390/9/01
Hi Daniel,
You're right that assertNotSame suites better here, i.e. it has nice
output in case of fai
Hi Joe,
Thank you for your suggestions. New webrev can be found here:
http://cr.openjdk.java.net/~aefimov/8173390/9/01
Hi Daniel,
You're right that assertNotSame suites better here, i.e. it has nice
output in case of failure. Because of that I removed the sout.println's
from the test too.
Wi
Hi Aleksej,
In the test:
75 Assert.assertNotEquals(symTable1, symTable2, "Symbol table
refence is the same");
I guess you meant Assert.assertNotSame - if what you want to do
is compare references.
(+ there is a typo in the message: refence => reference)
best regards,
-- daniel
On
Hi Aleksej,
I just realized there were other dependencies on the SymbolTable
instance initialized in the constructor (line 575 in your new code),
which was probably why you kept the code from 574 through 579 after
adding new SymbolTable for each parsing process (850 - 854). As a
result, the S
Hi,
Please, help to review the change required by JAXWS-RI code [1]:
SAXParser needs to reset internal SymbolTable to enable pooling of
parsers in SAAJ-RI code. Latest version of JAXWS-RI code (that is
currently under review [2]) doesn't provide a workaround to reset the
symbol table (it was
