Re: [9] RFR: JDK-8054548: JAX-WS tools need to updated to work with modular image

2014-09-12 Thread Alan Bateman
On 12/09/2014 11:51, Miroslav Kos wrote: If you are ok with it, I would proceed with this change as it is for now and improved generated classes would go into jdk9 with next regular sync integration. Yes, I'm okay with this. I do expect that additional changes will be needed later but we'll c

Re: [9] RFR: JDK-8054548: JAX-WS tools need to updated to work with modular image

2014-09-12 Thread Miroslav Kos
On 12/09/14 11:51, Alan Bateman wrote: On 12/09/2014 09:39, Miroslav Kos wrote: I agree that the code looks scary, but it's because we have to support range of jdk (currently jdk6 to jdk9) and we want to avoid maintaining several branches. The standalone project must work even with jdk6. The

Re: [9] RFR: JDK-8054548: JAX-WS tools need to updated to work with modular image

2014-09-12 Thread Alan Bateman
On 12/09/2014 09:39, Miroslav Kos wrote: I agree that the code looks scary, but it's because we have to support range of jdk (currently jdk6 to jdk9) and we want to avoid maintaining several branches. The standalone project must work even with jdk6. The magic here is to make the latest JAX-WS w

Re: [9] RFR: JDK-8054548: JAX-WS tools need to updated to work with modular image

2014-09-12 Thread Miroslav Kos
On 11/09/14 14:39, Alan Bateman wrote: On 11/09/2014 12:20, Miroslav Kos wrote: Hello, please review following change: JBS: https://bugs.openjdk.java.net/browse/JDK-8054548 webrev: http://cr.openjdk.java.net/~mkos/8054548/jaxws.00/ It is basically replacing obsolete code using core reflection b

Re: [9] RFR: JDK-8054548: JAX-WS tools need to updated to work with modular image

2014-09-11 Thread Alan Bateman
On 11/09/2014 12:20, Miroslav Kos wrote: Hello, please review following change: JBS: https://bugs.openjdk.java.net/browse/JDK-8054548 webrev: http://cr.openjdk.java.net/~mkos/8054548/jaxws.00/ It is basically replacing obsolete code using core reflection by javax.tools API plus removing old unu

[9] RFR: JDK-8054548: JAX-WS tools need to updated to work with modular image

2014-09-11 Thread Miroslav Kos
Hello, please review following change: JBS: https://bugs.openjdk.java.net/browse/JDK-8054548 webrev: http://cr.openjdk.java.net/~mkos/8054548/jaxws.00/ It is basically replacing obsolete code using core reflection by javax.tools API plus removing old unused code. I ran the unit tests against b