On Jun 6, 2014, at 3:25 AM, Paul Sandoz wrote:
>
> On Jun 6, 2014, at 11:31 AM, Vladimir Ivanov
> wrote:
>
>> John, Paul,
>>
>> I always welcome valuable suggestions, so here's an update :-)
>> http://cr.openjdk.java.net/~vlivanov/8032400/webrev.02/
>>
>> IMO, the test is much cleaner now.
On Jun 6, 2014, at 11:31 AM, Vladimir Ivanov
wrote:
> John, Paul,
>
> I always welcome valuable suggestions, so here's an update :-)
> http://cr.openjdk.java.net/~vlivanov/8032400/webrev.02/
>
> IMO, the test is much cleaner now.
>
Yes, I like it, easier to understand.
Paul.
John, Paul,
I always welcome valuable suggestions, so here's an update :-)
http://cr.openjdk.java.net/~vlivanov/8032400/webrev.02/
IMO, the test is much cleaner now.
Best regards,
Vladimir Ivanov
On 6/6/14 12:05 PM, Paul Sandoz wrote:
On Jun 6, 2014, at 1:17 AM, John Rose wrote:
Reviewed.
On Jun 6, 2014, at 1:17 AM, John Rose wrote:
> Reviewed.
>
> This is not a requirement, but I would prefer (in general) to see less test
> logic in ASM-generated bytecode and more in Java. I am guessing that the
> invokeExact call could have been replaced by a simple weakly-typed invoke
> c
Reviewed.
This is not a requirement, but I would prefer (in general) to see less test
logic in ASM-generated bytecode and more in Java. I am guessing that the
invokeExact call could have been replaced by a simple weakly-typed invoke call
in the framing code, and likewise with most of the other
Thanks for review, Paul.
Looks ok.
The behaviour of MethodHandles.Lookup.findSpecial got me confused for a while
:-)
Minor point: is it also worth exposing a T3.lookup() method and on the returned Lookup
calling findSpecial(T1.class, "m", MethodType.methodType(int.class),
T3.class).invokeE
On Jun 4, 2014, at 5:25 PM, Vladimir Ivanov
wrote:
> https://bugs.openjdk.java.net/browse/JDK-8032400
> http://cr.openjdk.java.net/~vlivanov/8032400/webrev.00/
>
> Consider the following hierarchy:
> class T1{int m() { return 1; }}
> class T2 extends T1 { static int m() {
https://bugs.openjdk.java.net/browse/JDK-8032400
http://cr.openjdk.java.net/~vlivanov/8032400/webrev.00/
Consider the following hierarchy:
class T1{int m() { return 1; }}
class T2 extends T1 { static int m() { return 2; }}
class T3 extends T2 {int m() { return 3;
