Hello,
Please review a couple of new tests for jarsigner's warnings. Basically
tests run jarsigner and check warning/error messages and exit codes
according to [1].
https://bugs.openjdk.java.net/browse/JDK-8049171
http://cr.openjdk.java.net/~asmotrak/8049171/webrev.00
[1]
http://docs.oracle
On 01/26/2015 11:11 AM, Wang Weijun wrote:
JarUtils:
You can break after line 83.
Sure, I have updated the webrev
http://cr.openjdk.java.net/~asmotrak/8049171/webrev.03/
Otherwise very good.
Thanks for reviewing this.
Thanks
Max
On Jan 26, 2015, at 15:55, Artem Smotrakov wrote:
Hi Max
JarUtils:
You can break after line 83.
Otherwise very good.
Thanks
Max
> On Jan 26, 2015, at 15:55, Artem Smotrakov wrote:
>
> Hi Max,
>
> Here is an updated webrev, please take a look.
>
> http://cr.openjdk.java.net/~asmotrak/8049171/webrev.02/
>
> Artem
>
> On 01/26/2015 05:03 AM, Weiju
Hi Max,
Here is an updated webrev, please take a look.
http://cr.openjdk.java.net/~asmotrak/8049171/webrev.02/
Artem
On 01/26/2015 05:03 AM, Weijun Wang wrote:
On 1/23/2015 16:12, Artem Smotrakov wrote:
If the MANIFEST and the signature files must be at the beginning, should
it be consider
On 1/23/2015 16:12, Artem Smotrakov wrote:
If the MANIFEST and the signature files must be at the beginning, should
it be considered as a bug in jarsigner? Should it reject such files?
I think so. Will file a bug.
The "jar u" way is to copy each old entry into destination unless the
entry
Hi Max,
Please see inline.
On 01/23/2015 05:18 AM, Wang Weijun wrote:
I have updated the webrev, updateJar() method does the following:
>- creates a new jar file (destJarFilename)
>- puts files which are specified in files parameter to destJarFilename
>- copies files from srcJarFilename to dest
> On Jan 22, 2015, at 19:40, Artem Smotrakov wrote:
>
>> I am not sure if I understand updateJar correctly. It looks like srcJarFile
>> is opened multiple times so its entries are duplicated a lot in the
>> destination. Or is there a secret break?
> There is no any secret, just a bug. It is no
Thanks, Max.
Please see inline.
On 01/21/2015 11:29 AM, Wang Weijun wrote:
Thanks for adding so many tests. Some suggestions:
- JarUtils.java
You can use the new InputStream.transferTo() method.
Sure, I didn't know about that, thanks.
I am not sure if I understand updateJar correctly. It l
Thanks for adding so many tests. Some suggestions:
- JarUtils.java
You can use the new InputStream.transferTo() method.
I am not sure if I understand updateJar correctly. It looks like srcJarFile is
opened multiple times so its entries are duplicated a lot in the destination.
Or is there a sec
