Re: [JAXP] RFR: 8153082: Update XSTL compiler to generate classes that invoke addReads

2016-07-26 Thread Daniel Fuchs
On 26/07/16 10:44, Alan Bateman wrote: On 25/07/2016 18:21, Daniel Fuchs wrote: Hi, Here is the later version of the fix: - Header files fixed - Bytecode 1.1 compatible http://cr.openjdk.java.net/~dfuchs/webrev_8153082/webrev.02/ This looks okay to me although I think I'd like to understand

Re: [JAXP] RFR: 8153082: Update XSTL compiler to generate classes that invoke addReads

2016-07-26 Thread Alan Bateman
On 25/07/2016 18:21, Daniel Fuchs wrote: Hi, Here is the later version of the fix: - Header files fixed - Bytecode 1.1 compatible http://cr.openjdk.java.net/~dfuchs/webrev_8153082/webrev.02/ This looks okay to me although I think I'd like to understand more as to why this needs to emit v45 c

RE: [JAXP] RFR: 8153082: Update XSTL compiler to generate classes that invoke addReads

2016-07-25 Thread Langer, Christoph
Fuchs [mailto:daniel.fu...@oracle.com] > Sent: Montag, 25. Juli 2016 19:22 > To: Langer, Christoph ; Joe Wang > ; Alan Bateman > Cc: core-libs-dev > Subject: Re: [JAXP] RFR: 8153082: Update XSTL compiler to generate classes > that invoke addReads > > Hi, > >

Re: [JAXP] RFR: 8153082: Update XSTL compiler to generate classes that invoke addReads

2016-07-25 Thread Daniel Fuchs
-dev Subject: Re: [JAXP] RFR: 8153082: Update XSTL compiler to generate classes that invoke addReads Hi, Here is the later version of the fix: - Header files fixed - Bytecode 1.1 compatible http://cr.openjdk.java.net/~dfuchs/webrev_8153082/webrev.02/ cheers, -- daniel On 25/07/16 16:16, Langer

Re: [JAXP] RFR: 8153082: Update XSTL compiler to generate classes that invoke addReads

2016-07-25 Thread Daniel Fuchs
-libs-dev Subject: Re: [JAXP] RFR: 8153082: Update XSTL compiler to generate classes that invoke addReads Hi Christoph, On 22/07/16 20:23, Langer, Christoph wrote: Hi Daniel, looks good to me. Maybe you'll want to take the chance to update the apache headers in the xalan files? Thank

RE: [JAXP] RFR: 8153082: Update XSTL compiler to generate classes that invoke addReads

2016-07-25 Thread Langer, Christoph
iel.fu...@oracle.com] > Sent: Montag, 25. Juli 2016 16:43 > To: Langer, Christoph > Cc: Joe Wang ; core-libs-dev d...@openjdk.java.net> > Subject: Re: [JAXP] RFR: 8153082: Update XSTL compiler to generate classes > that invoke addReads > > Hi Christoph, > > On 22/07/16 20

Re: [JAXP] RFR: 8153082: Update XSTL compiler to generate classes that invoke addReads

2016-07-25 Thread Daniel Fuchs
Hi Alan, On 23/07/16 07:57, Alan Bateman wrote: On 22/07/2016 17:16, Daniel Fuchs wrote: Hi, Please find below a fix for 8153082: Update XSTL compiler to generate classes that invoke addReads https://bugs.openjdk.java.net/browse/JDK-8153082 This fix removes a dependency from java.xml to an i

Re: [JAXP] RFR: 8153082: Update XSTL compiler to generate classes that invoke addReads

2016-07-25 Thread Daniel Fuchs
Hi Christoph, On 22/07/16 20:23, Langer, Christoph wrote: Hi Daniel, looks good to me. Maybe you'll want to take the chance to update the apache headers in the xalan files? Thanks for your review! I'm only an occasional wanderer in JAXP land - which files do you see have an outdated heade

Re: [JAXP] RFR: 8153082: Update XSTL compiler to generate classes that invoke addReads

2016-07-23 Thread huizhe wang
On 7/22/2016 11:57 PM, Alan Bateman wrote: On 22/07/2016 17:16, Daniel Fuchs wrote: Hi, Please find below a fix for 8153082: Update XSTL compiler to generate classes that invoke addReads https://bugs.openjdk.java.net/browse/JDK-8153082 This fix removes a dependency from java.xml to an inter

Re: [JAXP] RFR: 8153082: Update XSTL compiler to generate classes that invoke addReads

2016-07-22 Thread Alan Bateman
On 22/07/2016 17:16, Daniel Fuchs wrote: Hi, Please find below a fix for 8153082: Update XSTL compiler to generate classes that invoke addReads https://bugs.openjdk.java.net/browse/JDK-8153082 This fix removes a dependency from java.xml to an internal java base API. This looks good. The only t

RE: [JAXP] RFR: 8153082: Update XSTL compiler to generate classes that invoke addReads

2016-07-22 Thread Langer, Christoph
Freitag, 22. Juli 2016 18:16 > To: core-libs-dev > Subject: [JAXP] RFR: 8153082: Update XSTL compiler to generate classes that > invoke addReads > > Hi, > > Please find below a fix for > 8153082: Update XSTL compiler to generate classes that invoke addReads > http

[JAXP] RFR: 8153082: Update XSTL compiler to generate classes that invoke addReads

2016-07-22 Thread Daniel Fuchs
Hi, Please find below a fix for 8153082: Update XSTL compiler to generate classes that invoke addReads https://bugs.openjdk.java.net/browse/JDK-8153082 This fix removes a dependency from java.xml to an internal java base API. http://cr.openjdk.java.net/~dfuchs/webrev_8153082/webrev.00/ It chan