Re: [JAXP] RFR: 8169778: Add new public methods to get new instances of the JAXP factories builtin system-default implementations

2016-11-17 Thread Daniel Fuchs
Hi, On 17/11/16 17:51, Joe Wang wrote: > Hi Daniel, > > Would you think we need to use a consistent description between: > the xxxFactory builtin system-default implementation. > and > The builtin system-default xxxFactory implementation > > That seems to appear only in

Re: [JAXP] RFR: 8169778: Add new public methods to get new instances of the JAXP factories builtin system-default implementations

2016-11-16 Thread Daniel Fuchs
Thanks Roger, On 16/11/16 16:03, Roger Riggs wrote: Hi Daniel, DocumentBuilderFactory and classes: - The new methods uses "Creates" instead of "Obtain"; perhaps it should be consistent with existing newInstance methods? I had some pre-review advice from Joe (Wang) about who suggested

Re: [JAXP] RFR: 8169778: Add new public methods to get new instances of the JAXP factories builtin system-default implementations

2016-11-16 Thread Lance Andersen
> On Nov 16, 2016, at 12:18 PM, Joe Wang wrote: > > > > On 11/16/16, 8:03 AM, Roger Riggs wrote: >> Hi Daniel, >> >> DocumentBuilderFactory and classes: >> - The new methods uses "Creates" instead of "Obtain"; >> perhaps it should be consistent with existing

Re: [JAXP] RFR: 8169778: Add new public methods to get new instances of the JAXP factories builtin system-default implementations

2016-11-16 Thread Joe Wang
On 11/16/16, 8:03 AM, Roger Riggs wrote: Hi Daniel, DocumentBuilderFactory and classes: - The new methods uses "Creates" instead of "Obtain"; perhaps it should be consistent with existing newInstance methods? "Obtain" was used in the early version of JAXP, and "Creates" in newer

Re: [JAXP] RFR: 8169778: Add new public methods to get new instances of the JAXP factories builtin system-default implementations

2016-11-16 Thread Roger Riggs
Hi Daniel, DocumentBuilderFactory and classes: - The new methods uses "Creates" instead of "Obtain"; perhaps it should be consistent with existing newInstance methods? - "Otherwise," and "Otherwise" (with and without ",") are not consistent in the webrev. XMLInputFactory.java:

[JAXP] RFR: 8169778: Add new public methods to get new instances of the JAXP factories builtin system-default implementations

2016-11-16 Thread Daniel Fuchs
Hi, Please find below a patch for: 8169778: Add new public methods to get new instances of the JAXP factories builtin system-default implementations bug: https://bugs.openjdk.java.net/browse/JDK-8169778 webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8169778/webrev.00/ best regards,