Re: RFR: 8242186: Reduce allocations in URLStreamHandler.parseURL for some cases (Was: Re: [NEW BUG] Small optimization in URLStreamHandler.parseURL)

2020-04-06 Thread Claes Redestad
On 2020-04-06 13:22, Chris Hegarty wrote: Bug:https://bugs.openjdk.java.net/browse/JDK-8242186 Let me know if there are any concerns, otherwise I'll push once tier1 testing comes back green. Thanks! Thanks all for this nice micro-optimization. The changes look good to me. -Chris. Thanks,

Re: RFR: 8242186: Reduce allocations in URLStreamHandler.parseURL for some cases (Was: Re: [NEW BUG] Small optimization in URLStreamHandler.parseURL)

2020-04-06 Thread Chris Hegarty
> On 6 Apr 2020, at 11:29, Claes Redestad wrote: > > Hi, > > (including net-dev@.. since this is in java.net) > > I intend to sponsor this trivial patch provided by Christoph: > > diff -r 65b345254ca3 > src/java.base/share/classes/java/net/URLStreamHandler.java > --- a/src/java.base/share/

RFR: 8242186: Reduce allocations in URLStreamHandler.parseURL for some cases (Was: Re: [NEW BUG] Small optimization in URLStreamHandler.parseURL)

2020-04-06 Thread Claes Redestad
Hi, (including net-dev@.. since this is in java.net) I intend to sponsor this trivial patch provided by Christoph: diff -r 65b345254ca3 src/java.base/share/classes/java/net/URLStreamHandler.java --- a/src/java.base/share/classes/java/net/URLStreamHandler.java Thu Apr 02 05:44:04 2020 + +

Re: [NEW BUG] Small optimization in URLStreamHandler.parseURL

2020-04-05 Thread Claes Redestad
Hi Christoph, looks good and trivial. I'll sponsor. /Claes On 2020-04-05 10:57, Christoph Dreis wrote: Hi, I just noticed a small optimization opportunity in URLStreamHandler.parseURL for inputs like the following: new URL(new URL("file:"), "file:./path/to/some/local.properties");

[NEW BUG] Small optimization in URLStreamHandler.parseURL

2020-04-05 Thread Christoph Dreis
Hi, I just noticed a small optimization opportunity in URLStreamHandler.parseURL for inputs like the following: new URL(new URL("file:"), "file:./path/to/some/local.properties"); In those cases there is no authority involved, which makes it possible to rewrite URLStreamHandler:L269-270