Re: [PATCH] 8218268: Javac treats Manifest Class-Path entries as Paths instead of URLs

2019-03-13 Thread Jonathan Gibbons
Donald, While it was reasonable to raise the spec issues on core-libs-dev, any/all questions about javac code should be addressed to compiler-...@openjdk.java.net. That being said, * any comment labelled "// TODO" in new code seems questionable * the copyright date on the test is wrong and

Re: [PATCH] 8218268: Javac treats Manifest Class-Path entries as Paths instead of URLs

2019-03-13 Thread Donald Kwakkel
Attached patch with tests so first the bug for java11 can be fixed and backported. Would be nice if someone can guide me how to continue with this and/or can reply on my previous questions. Op di 5 mrt. 2019 om 07:11 schreef Donald Kwakkel : > > > On 02/28/2019 01:06 PM, Alan Bateman wrote: > > >

Re: [PATCH] 8218268: Javac treats Manifest Class-Path entries as Paths instead of URLs

2019-03-11 Thread Brent Christian
Hi, Jon On 2/28/19 1:38 PM, Jonathan Gibbons wrote: On 28/02/2019 20:58, Jonathan Gibbons wrote: Looking at the revised JAR specification, approved in [1], it is disappointing that the spec contains text which is specific to a JAR file being used in a classloader: |The resulting URLs are ins

Re: [PATCH] 8218268: Javac treats Manifest Class-Path entries as Paths instead of URLs

2019-03-04 Thread Donald Kwakkel
> On 02/28/2019 01:06 PM, Alan Bateman wrote: > > On 28/02/2019 20:58, Jonathan Gibbons wrote: > >> Looking at the revised JAR specification, approved in [1], it is > >> disappointing that the spec contains text which is specific to > >> a JAR file being used in a classloader: > >> > >> |The result

Re: [PATCH] 8218268: Javac treats Manifest Class-Path entries as Paths instead of URLs

2019-02-28 Thread Jonathan Gibbons
On 02/28/2019 01:06 PM, Alan Bateman wrote: On 28/02/2019 20:58, Jonathan Gibbons wrote: Looking at the revised JAR specification, approved in [1], it is disappointing that the spec contains text which is specific to a JAR file being used in a classloader: |The resulting URLs are inserted in

Re: [PATCH] 8218268: Javac treats Manifest Class-Path entries as Paths instead of URLs

2019-02-28 Thread Alan Bateman
On 28/02/2019 20:58, Jonathan Gibbons wrote: Looking at the revised JAR specification, approved in [1], it is disappointing that the spec contains text which is specific to a JAR file being used in a classloader: |The resulting URLs are inserted into the search path of the class loader opening

Re: [PATCH] 8218268: Javac treats Manifest Class-Path entries as Paths instead of URLs

2019-02-28 Thread Jonathan Gibbons
Looking at the revised JAR specification, approved in [1], it is disappointing that the spec contains text which is specific to a JAR file being used in a classloader: |The resulting URLs are inserted into the search path of the class loader opening the context JAR immediately following the path

[PATCH] 8218268: Javac treats Manifest Class-Path entries as Paths instead of URLs

2019-02-28 Thread Donald Kwakkel
a Hi All, This is my first contribution to openjdk, so hope to learn a lot! I first posted this to compiler-dev, but they explained that I better can discuss this first on this list. I created a fix + tests for https://bugs.openjdk.java.net/browse/JDK-8218268 (I will rewrite the test to java usi