Re: [PATCH] Duplicated indexOf/lasIndexOf in array-based collections

2018-03-26 Thread Paul Sandoz
> On Mar 26, 2018, at 11:46 AM, Martin Buchholz wrote: > > Сергей, I'm sort of maintaining all those collection classes, and I have on > occasion also wanted to have indexOf methods in Array.java. But: > > Arrays are generally discouraged. Any new static methods on Arrays (or, > where I actu

Re: [PATCH] Duplicated indexOf/lasIndexOf in array-based collections

2018-03-26 Thread Martin Buchholz
Сергей, I'm sort of maintaining all those collection classes, and I have on occasion also wanted to have indexOf methods in Array.java. But: Arrays are generally discouraged. Any new static methods on Arrays (or, where I actually want them, on the array object itself! Requires a java language c

[PATCH] Duplicated indexOf/lasIndexOf in array-based collections

2018-03-10 Thread Сергей Цыпанов
Hi everyone, currently array-based collections, in particular java.util.ArrayList, java.util.Arrays$ArrayList, java.util.Vector, java.util.concurrent.CopyOnWriteArrayList have duplicated code in indexOf() and lastIndexOf(). My proposal is to extract this code into java.util.Arrays helping JIT