Re: [PATCH] JDK-8155102: Process.toString could include pid, isAlive, exitStatus

2016-08-01 Thread Andrey Dyachkov
Roger, I have changed impl according to your comments, thank you! Regarding fc-extension, I am not able to add comments in the bug tracker I think you can do it, correct? Also I am already in OCA list. diff --git a/src/java.base/unix/classes/java/lang/ProcessImpl.java

Re: [PATCH] JDK-8155102: Process.toString could include pid, isAlive, exitStatus

2016-08-01 Thread Roger Riggs
Hi Andrey, Sorry to be slow in getting back to this. Thanks for the update; did you notice that Windows has a separate implementation of ProcessImpl and would also need a similar, though not identical toString() implementation?

Re: [PATCH] JDK-8155102: Process.toString could include pid, isAlive, exitStatus

2016-07-24 Thread Andrey Dyachkov
Hi Roger, Thank you for reviewing it! I've prepared another version. diff --git a/src/java.base/unix/classes/java/lang/ProcessImpl.java b/src/java.base/unix/classes/java/lang/ProcessImpl.java --- a/src/java.base/unix/classes/java/lang/ProcessImpl.java +++

[PATCH] JDK-8155102: Process.toString could include pid, isAlive, exitStatus

2016-05-09 Thread Andrey Dyachkov
Hello, I have added toString() method in Process.java. diff --git a/src/java.base/share/classes/java/lang/Process.java b/src/java.base/share/classes/java/lang/Process.java --- a/src/java.base/share/classes/java/lang/Process.java +++ b/src/java.base/share/classes/java/lang/Process.java @@ -548,5

Re: [PATCH] JDK-8155102: Process.toString could include pid, isAlive, exitStatus

2016-05-09 Thread Roger Riggs
Hi Andrey, Since toString is a public method it needs to provide complete javadoc specification as providing values for debugging information. ToString methods typically directly reflect the state of the fields of the object. Why should the exitValue have the value of the pid if the process

[PATCH] JDK-8155102: Process.toString could include pid, isAlive, exitStatus

2016-05-08 Thread Andrey Dyachkov
Hello, I have added toString() method in Process.java. diff --git a/src/java.base/share/classes/java/lang/Process.java b/src/java.base/share/classes/java/lang/Process.java --- a/src/java.base/share/classes/java/lang/Process.java +++ b/src/java.base/share/classes/java/lang/Process.java @@ -548,5