- Original Message -
> On 07/11/2012 20:51, Andrew Hughes wrote:
> > :
> >
> > As you can see on the IcedTea bug, I've asked the same question.
> > I'd have preferred it to use try-with-resources myself (easier to
> > follow for one thing), but given the patch is as it is, I'm now
> > wary
- Original Message -
> On 8/11/2012 7:17 AM, Andrew Hughes wrote:
> > - Original Message -
> >> The bug number is 8003120
> >>
> >
> > Thanks. Pushed to tl:
> > http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f51943263267
>
> I did not construe Lance's mail to indicate an approval to p
On 07/11/2012 20:51, Andrew Hughes wrote:
:
As you can see on the IcedTea bug, I've asked the same question.
I'd have preferred it to use try-with-resources myself (easier to
follow for one thing), but given the patch is as it is, I'm now
wary about changing it and negating the existing testing
On 8/11/2012 7:17 AM, Andrew Hughes wrote:
- Original Message -
The bug number is 8003120
Thanks. Pushed to tl: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f51943263267
I did not construe Lance's mail to indicate an approval to push. The
turnaround on this was just a bit too quick
- Original Message -
> The bug number is 8003120
>
Thanks. Pushed to tl: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f51943263267
> Best
> Lance
> On Nov 7, 2012, at 3:30 PM, Andrew Hughes wrote:
>
> > IcedTea bug:
> > http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1197
> >
> >
- Original Message -
> Is there a reason the patch was not created originally leveraging
> try-with-resources as it seems like the perfect candidate from the
> webrev?
>
> I can create a bug for it, but I think I would prefer to see the
> patch take advantage of try-with-resoruces
>
As y
The bug number is 8003120
Best
Lance
On Nov 7, 2012, at 3:30 PM, Andrew Hughes wrote:
> IcedTea bug: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1197
>
> com.sun.naming.internal.ResourceManager.getApplicationResources() does not
> close the input streams it gets from helper.getResourc
Is there a reason the patch was not created originally leveraging
try-with-resoruces as it seems like the perfect candidate from the webrev?
I can create a bug for it, but I think I would prefer to see the patch take
advantage of try-with-resoruces
Best
Lance
On Nov 7, 2012, at 3:30 PM, Andrew
IcedTea bug: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=1197
com.sun.naming.internal.ResourceManager.getApplicationResources() does not
close the input streams it gets from helper.getResources() and
helper.getJavaHomeLibStream(). This patch:
http://cr.openjdk.java.net/~andrew/pr1197
