Re: [RFR]: 8131334: SAAJ Plugability Layer: using java.util.ServiceLoader

Hi Miran, On Nov 20, 2015, at 10:29 AM, Miroslav Kos wrote: > On 20/11/15 15:25, Daniel Fuchs wrote: >> On 20/11/15 09:43, Miroslav Kos wrote: >>> Locally, it worked for me, but I understand that it's dengerous - global >>> state is evil ... I removed all the

Re: [RFR]: 8131334: SAAJ Plugability Layer: using java.util.ServiceLoader

On 20/11/15 09:43, Miroslav Kos wrote: Locally, it worked for me, but I understand that it's dengerous - global state is evil ... I removed all the scenarios modifying JDK/conf/ dir - I just commented out those parts so if necessary, it can be uncommented and run locally.

Re: [RFR]: 8131334: SAAJ Plugability Layer: using java.util.ServiceLoader

On 20/11/15 15:25, Daniel Fuchs wrote: On 20/11/15 09:43, Miroslav Kos wrote: Locally, it worked for me, but I understand that it's dengerous - global state is evil ... I removed all the scenarios modifying JDK/conf/ dir - I just commented out those parts so if necessary, it can be uncommented

Re: [RFR]: 8131334: SAAJ Plugability Layer: using java.util.ServiceLoader

Locally, it worked for me, but I understand that it's dengerous - global state is evil ... I removed all the scenarios modifying JDK/conf/ dir - I just commented out those parts so if necessary, it can be uncommented and run locally. http://cr.openjdk.java.net/~mkos/8131334/jdk.02/ Thanks

Re: [RFR]: 8131334: SAAJ Plugability Layer: using java.util.ServiceLoader

On 11/19/2015 12:45 PM, Alan Bateman wrote: On 19/11/2015 18:36, Daniel Fuchs wrote: Hi Miran, I would expect this to fail horribly - you may not have the right to create anything under $JAVA_HOME/conf - it may even be a read-only file system... And I would be very uneasy as this may have

Re: [RFR]: 8131334: SAAJ Plugability Layer: using java.util.ServiceLoader

Hi Lance, I added jtreg test(s) - http://cr.openjdk.java.net/~mkos/8131334/jdk.01/index.html There are several scenarios being tested, all without/with SM. The test preparation I am doing in java (based on test args), so the test creates/deletes $JAVA_HOME/conf/jaxm.properties. Hopefully

Re: [RFR]: 8131334: SAAJ Plugability Layer: using java.util.ServiceLoader

On 19/11/2015 18:36, Daniel Fuchs wrote: Hi Miran, I would expect this to fail horribly - you may not have the right to create anything under $JAVA_HOME/conf - it may even be a read-only file system... And I would be very uneasy as this may have side effects on tests executing later on if

Re: [RFR]: 8131334: SAAJ Plugability Layer: using java.util.ServiceLoader

On 19/11/15 18:31, Miroslav Kos wrote: Hi Lance, I added jtreg test(s) - http://cr.openjdk.java.net/~mkos/8131334/jdk.01/index.html There are several scenarios being tested, all without/with SM. The test preparation I am doing in java (based on test args), so the test creates/deletes

Re: [RFR]: 8131334: SAAJ Plugability Layer: using java.util.ServiceLoader

.. anyone? On 10/11/15 15:31, Miroslav Kos wrote: Ping ... Would somebody find time for this one? Thanks M. On 26/10/15 13:59, Miroslav Kos wrote: Hi everybody, I'd like to ask you for a review for 8131334: SAAJ Plugability Layer: using java.util.ServiceLoader It is about changes in

Re: [RFR]: 8131334: SAAJ Plugability Layer: using java.util.ServiceLoader

Hi, Overall it looks ok, I would however suggest adding a couple of tests to the jdk that run with/out a security manager as a sanity check. Best Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803

Re: [RFR]: 8131334: SAAJ Plugability Layer: using java.util.ServiceLoader

Not sure exactly what you want to set, but you can set system properties or run tests from a script or from testNG For running a script, see http://openjdk.java.net/jtreg/vmoptions.html Best Lance On Nov 12, 2015, at 8:28 AM, Miroslav Kos wrote: > I have a set of

Re: [RFR]: 8131334: SAAJ Plugability Layer: using java.util.ServiceLoader

I have a set of tests in standalone project (using bash scripts), but the problem is that to test the correct behavior, configuring of jdk is necessary (property file) - have no idea if something like this is possible with jtreg - are there any similat tests already? Thanks Miran On 12/11/15

Re: [RFR]: 8131334: SAAJ Plugability Layer: using java.util.ServiceLoader

Ping ... Would somebody find time for this one? Thanks M. On 26/10/15 13:59, Miroslav Kos wrote: Hi everybody, I'd like to ask you for a review for 8131334: SAAJ Plugability Layer: using java.util.ServiceLoader It is about changes in pluggability layer - there was a proprietary service

[RFR]: 8131334: SAAJ Plugability Layer: using java.util.ServiceLoader

Hi everybody, I'd like to ask you for a review for 8131334: SAAJ Plugability Layer: using java.util.ServiceLoader It is about changes in pluggability layer - there was a proprietary service loading implementation which was not fully compatible with to use java.util.ServiceLoader facility.