Re: [jdk16] RFR: 8260927: StringBuilder::insert is incorrect without Compact Strings [v2]

2021-02-02 Thread Aleksey Shipilev
On Tue, 2 Feb 2021 15:32:16 GMT, Jim Laskey wrote: >> Aleksey Shipilev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add the regression test case > > Marked as reviewed by jlaskey (Reviewer). Thanks. GHA are green, `tier1`, `tier2` ar

Re: [jdk16] RFR: 8260927: StringBuilder::insert is incorrect without Compact Strings [v2]

2021-02-02 Thread Jim Laskey
On Tue, 2 Feb 2021 13:31:58 GMT, Aleksey Shipilev wrote: >> Discovered it with ARM32 tier1 tests, which runs with -CompactStrings by >> default. But the bug is actually generic: >> >> $ CONF=linux-x86_64-server-fastdebug make run-test >> TEST=java/lang/StringBuilder/Insert.java TEST_VM_OPTS="-

Re: [jdk16] RFR: 8260927: StringBuilder::insert is incorrect without Compact Strings [v2]

2021-02-02 Thread Roger Riggs
On Tue, 2 Feb 2021 13:31:58 GMT, Aleksey Shipilev wrote: >> Discovered it with ARM32 tier1 tests, which runs with -CompactStrings by >> default. But the bug is actually generic: >> >> $ CONF=linux-x86_64-server-fastdebug make run-test >> TEST=java/lang/StringBuilder/Insert.java TEST_VM_OPTS="-

Re: [jdk16] RFR: 8260927: StringBuilder::insert is incorrect without Compact Strings [v2]

2021-02-02 Thread Alan Bateman
On Tue, 2 Feb 2021 13:31:58 GMT, Aleksey Shipilev wrote: >> Discovered it with ARM32 tier1 tests, which runs with -CompactStrings by >> default. But the bug is actually generic: >> >> $ CONF=linux-x86_64-server-fastdebug make run-test >> TEST=java/lang/StringBuilder/Insert.java TEST_VM_OPTS="-

Re: [jdk16] RFR: 8260927: StringBuilder::insert is incorrect without Compact Strings [v2]

2021-02-02 Thread Claes Redestad
On Tue, 2 Feb 2021 13:31:58 GMT, Aleksey Shipilev wrote: >> Discovered it with ARM32 tier1 tests, which runs with -CompactStrings by >> default. But the bug is actually generic: >> >> $ CONF=linux-x86_64-server-fastdebug make run-test >> TEST=java/lang/StringBuilder/Insert.java TEST_VM_OPTS="-

Re: [jdk16] RFR: 8260927: StringBuilder::insert is incorrect without Compact Strings [v2]

2021-02-02 Thread Aleksey Shipilev
> Discovered it with ARM32 tier1 tests, which runs with -CompactStrings by > default. But the bug is actually generic: > > $ CONF=linux-x86_64-server-fastdebug make run-test > TEST=java/lang/StringBuilder/Insert.java TEST_VM_OPTS="-XX:-CompactStrings" > > test Insert.insertOffset(): failure > j

Re: [jdk16] RFR: 8260927: StringBuilder::insert is incorrect without Compact Strings [v2]

2021-02-02 Thread Aleksey Shipilev
On Tue, 2 Feb 2021 13:23:16 GMT, Claes Redestad wrote: > Should we add an explicit run with -CompactStrings to the Insert.java test? > That'd have caught this issue sooner - perhaps already by the GA testing. Yes, I thought about the same. Added and re-checked that it catches the failure. (I a

Re: [jdk16] RFR: 8260927: StringBuilder::insert is incorrect without Compact Strings

2021-02-02 Thread Claes Redestad
On Tue, 2 Feb 2021 13:12:53 GMT, Aleksey Shipilev wrote: > Discovered it with ARM32 tier1 tests, which runs with -CompactStrings by > default. But the bug is actually generic: > > $ CONF=linux-x86_64-server-fastdebug make run-test > TEST=java/lang/StringBuilder/Insert.java TEST_VM_OPTS="-XX:-C

[jdk16] RFR: 8260927: StringBuilder::insert is incorrect without Compact Strings

2021-02-02 Thread Aleksey Shipilev
Discovered it with ARM32 tier1 tests, which runs with -CompactStrings by default. But the bug is actually generic: $ CONF=linux-x86_64-server-fastdebug make run-test TEST=java/lang/StringBuilder/Insert.java TEST_VM_OPTS="-XX:-CompactStrings" test Insert.insertOffset(): failure java.lang.Asserti