Re: [jdk18] RFR: 8279833: Loop optimization issue in String.encodeUTF8_UTF16

2022-01-13 Thread Kevin Rushforth
On Thu, 13 Jan 2022 15:23:25 GMT, Claes Redestad wrote: > I've taken up the (bad?) habit of creating it manually to keep a tab on my > current tasks and intents. I do that too in some cases, and for the same reason. The only potential downside is if you create a concrete version for a specific

Re: [jdk18] RFR: 8279833: Loop optimization issue in String.encodeUTF8_UTF16

2022-01-13 Thread Claes Redestad
On Thu, 13 Jan 2022 15:14:05 GMT, Kevin Rushforth wrote: >>> LGTM >> >> Thanks! >> >>> (This a backport but is using the mainline bug number; already resolved). >> >> I think that's intentional? I entered "Backport COMMITHASH" as the PR >> subject as per instructions and the bots have taken t

Re: [jdk18] RFR: 8279833: Loop optimization issue in String.encodeUTF8_UTF16

2022-01-13 Thread Kevin Rushforth
On Thu, 13 Jan 2022 15:05:42 GMT, Claes Redestad wrote: > > (This a backport but is using the mainline bug number; already resolved). > > I think that's intentional? I entered "Backport COMMITHASH" as the PR subject > as per instructions and the bots have taken things from there. Yes, it's bot

Re: [jdk18] RFR: 8279833: Loop optimization issue in String.encodeUTF8_UTF16

2022-01-13 Thread Claes Redestad
On Thu, 13 Jan 2022 14:56:50 GMT, Roger Riggs wrote: > LGTM Thanks! > (This a backport but is using the mainline bug number; already resolved). I think that's intentional? I entered "Backport COMMITHASH" as the PR subject as per instructions and the bots have taken things from there. ---

Re: [jdk18] RFR: 8279833: Loop optimization issue in String.encodeUTF8_UTF16

2022-01-13 Thread Roger Riggs
On Thu, 13 Jan 2022 13:46:53 GMT, Claes Redestad wrote: > 8279833: Loop optimization issue in String.encodeUTF8_UTF16 LGTM (This a backport but is using the mainline bug number; already resolved). - Marked as reviewed by rriggs (Reviewer). PR: https://git.openjdk.java.net/jdk18/pu

[jdk18] RFR: 8279833: Loop optimization issue in String.encodeUTF8_UTF16

2022-01-13 Thread Claes Redestad
8279833: Loop optimization issue in String.encodeUTF8_UTF16 - Commit messages: - 8279833: Loop optimization issue in String.encodeUTF8_UTF16 Changes: https://git.openjdk.java.net/jdk18/pull/99/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18&pr=99&range=00 Issue: https: