Re: [jdk9] RFR: 8159822: Non-synchronized access to shared members of com.sun.jndi.ldap.pool.Pool

2016-06-30 Thread Ivan Gerasimov
Thanks Seán! I added an example of stacktrace to the description. With kind regards, Ivan On 30.06.2016 17:31, Seán Coffey wrote: Looks fine to me Ivan. If you have a stacktrace of an example ConcurrentModificationException issue, please paste it into the bug report so that it's documented

Re: [jdk9] RFR: 8159822: Non-synchronized access to shared members of com.sun.jndi.ldap.pool.Pool

2016-06-30 Thread Seán Coffey
Looks fine to me Ivan. If you have a stacktrace of an example ConcurrentModificationException issue, please paste it into the bug report so that it's documented for others to find. Regards, Sean. On 24/06/2016 15:56, Ivan Gerasimov wrote: Hi Aleksey! I've double-checked the Pool class and

Re: [jdk9] RFR: 8159822: Non-synchronized access to shared members of com.sun.jndi.ldap.pool.Pool

2016-06-24 Thread Ivan Gerasimov
Hi Aleksey! I've double-checked the Pool class and found no other code that has to be additionally synchronized. Please note that the method expungeStaleConnections() is thread-safe and can be called from outside the synchronized blocks. The method Pool.getConnections(Object) accesses the `map`

Re: [jdk9] RFR: 8159822: Non-synchronized access to shared members of com.sun.jndi.ldap.pool.Pool

2016-06-21 Thread Ivan Gerasimov
On 21.06.2016 18:43, Aleksey Shipilev wrote: On 06/21/2016 06:14 PM, Ivan Gerasimov wrote: Hello! The Pool has a member `map`, which is accessed from different threads, thus the access is synchronized. However, in some code paths (mostly in debug printing) it is accessed without proper synchr

Re: [jdk9] RFR: 8159822: Non-synchronized access to shared members of com.sun.jndi.ldap.pool.Pool

2016-06-21 Thread Aleksey Shipilev
On 06/21/2016 06:14 PM, Ivan Gerasimov wrote: > Hello! > > The Pool has a member `map`, which is accessed from different threads, > thus the access is synchronized. > However, in some code paths (mostly in debug printing) it is accessed > without proper synchronization, which results in intermedia

[jdk9] RFR: 8159822: Non-synchronized access to shared members of com.sun.jndi.ldap.pool.Pool

2016-06-21 Thread Ivan Gerasimov
Hello! The Pool has a member `map`, which is accessed from different threads, thus the access is synchronized. However, in some code paths (mostly in debug printing) it is accessed without proper synchronization, which results in intermediate ConcurrentModificationException when the debug outp