You can push it to jdk9-dev directly. No other reviewer is required.
Regards,
Volker
On Tue, Apr 15, 2014 at 9:48 AM, Jonathan Lu wrote:
> Hi Masayoshi, Volker,
>
> Thanks a lot for reviewing !
> Is it OK for me to push the change into JDK9 directly ? or need another
> reviewer's approval ?
>
>
Hi Masayoshi, Volker,
Thanks a lot for reviewing !
Is it OK for me to push the change into JDK9 directly ? or need another
reviewer's approval ?
Many thanks
Jonathan
On Mon, Apr 14, 2014 at 2:03 PM, Masayoshi Okutsu <
masayoshi.oku...@oracle.com> wrote:
> Looks good to me.
>
> Thanks,
> Masa
Looks good to me.
Thanks,
Masayoshi
On 4/11/2014 10:46 PM, Volker Simonis wrote:
Hi Jonathan,
thank you for fixing all the remaining issues. From my point of view
this change looks good now.
@Masayoshi: can I please get a final approval from you for pushing the
change? I also want to downp
Hi Jonathan,
thank you for fixing all the remaining issues. From my point of view this
change looks good now.
@Masayoshi: can I please get a final approval from you for pushing the
change? I also want to downport this to 8u-dev but I don't think that's a
big deal as this only touches AX code.
Th
Hi Volker,
Thanks a lot for your comments, I've made another patch,
http://cr.openjdk.java.net/~luchsh/JDK-8034220.v4/
On Fri, Apr 4, 2014 at 9:22 PM, Volker Simonis wrote:
> Hi Jonathan,
>
> sorry, but I found a few more issues:
>
> - please use strncpy instead of strcpy in TimeZone_md.c:798
Hi Jonathan,
sorry, but I found a few more issues:
- please use strncpy instead of strcpy in TimeZone_md.c:798 otherwise
somebody could easily crash the VM by specifying a TZ with more than
100 characters.
- you can delete the lines 871-872 because the variables are actually
not used and you can
Hi Volker, Masayoshi,
I made another patch which fixed the problems mentioned in last mail,
http://cr.openjdk.java.net/~luchsh/JDK-8034220.v3/
Could you pls help to take a look?
Many thanks
Jonathan
On Thu, Apr 3, 2014 at 12:34 AM, Jonathan Lu wrote:
> Hi Volker,
>
>
> On 2014年04月02日 23:0
Hi Volker,
On 2014年04月02日 23:07, Volker Simonis wrote:
Hi Jonathan,
thanks for updating the change. Please find my comments inline:
On Tue, Apr 1, 2014 at 4:52 PM, Jonathan Lu
wrote:
Hi Volker, Masayoshi,
Thanks a lot for your review, here's the updated patch, could you pls take a
look?
h
Hi Jonathan,
thanks for updating the change. Please find my comments inline:
On Tue, Apr 1, 2014 at 4:52 PM, Jonathan Lu wrote:
> Hi Volker, Masayoshi,
>
> Thanks a lot for your review, here's the updated patch, could you pls take a
> look?
>
> http://cr.openjdk.java.net/~luchsh/JDK-8034220.v2/
Hi Volker, Masayoshi,
Thanks a lot for your review, here's the updated patch, could you pls take
a look?
http://cr.openjdk.java.net/~luchsh/JDK-8034220.v2/
On Thu, Mar 27, 2014 at 1:48 AM, Volker Simonis wrote:
> Hi Jonathan,
>
> thanks for doing this change. Please find some comments below:
>
Hi Volker,
You are right. The `tz' value needs to be given to
getPlatformTimeZoneID() or the getenv() call should be moved to the
function. Your mapPlatformToJavaTimzone(const char* tz) sounds good to me.
In any case TimeZone_md.c has become too messy by accumulating
platform/release-specifi
Hi Jonathan,
thanks for doing this change. Please find some comments below:
1. please update the copyright year to 2014 in every file you touch
2. in CopyFiles.gmk you can simplify the change by joining the windows
and aix cases because on Windows OPENJDK_TARGET_OS is the same like
OPENJDK_TARGE
Hi Jonathan,
The AIX specific code looks OK to me. But I'd suggest the code be moved
to getPlatformTimeZoneID() for AIX, which just returns NULL currently.
Also there's a function for producing a fallback ID in "GMT±hh:mm",
getGMTOffsetID() which can be called in tzerr.
Thanks,
Masayoshi
On
Adding i18n-dev to the thread as i18n-dev is where the TZ code is
maintained.
On 26/03/2014 06:47, Jonathan Lu wrote:
Hi ppc-aix-port-dev, core-libs-dev,
Here's a patch for JDK-8034220,
http://cr.openjdk.java.net/~luchsh/JDK-8034220/
It is trying to add the a more complete timezone mapping
Hi ppc-aix-port-dev, core-libs-dev,
Here's a patch for JDK-8034220,
http://cr.openjdk.java.net/~luchsh/JDK-8034220/
It is trying to add the a more complete timezone mapping mechanism for AIX
platform.
the changes are primarily based on IBM's commercial JDK code, which
includes:
- A new timezone
15 matches
Mail list logo
