Hello Naoto.
Yes, I agree with your suggestion.
I'm very happy if you are the sponsor of this issue.
Thanks,
Ichiroh Takiguchi
On 2020-02-22 01:53, naoto.s...@oracle.com wrote:
Two subtle comments to the new webrev:
- I'd add "private" to those static finals.
- "cs.name()" in the exception me
Two subtle comments to the new webrev:
- I'd add "private" to those static finals.
- "cs.name()" in the exception messages can be replaced with "csName".
Otherwise it looks good. If you agree with the above, no further review
is needed. Also, if you need a sponsor, I can sponsor your changeset.
Hello Naoto.
I appreciate your suggestions.
I applied your suggestions into new patch.
Could you review the fix again ?
Bug:https://bugs.openjdk.java.net/browse/JDK-8235834
Change: https://cr.openjdk.java.net/~itakiguchi/8235834/webrev.01/
Thanks,
Ichiroh Takiguchi
IBM Japan, Ltd.
On 2020-
Thanks for the explanation. Here are comments to your fix:
- Can you add some comments about the gist of the change to IBM943.c2b?
Summarizing the explanation below would be fine.
For the test case:
- Please wrap the @bug line appropriately.
- Those byte array/Strings can be "static final" o
Hello Naoto.
I appreciate your comment.
The definition has not changed recently.
Applying the change will prevent the characters which are used on
Japanese PC from being converted to "?".
I checked IBM-943 definition and changelog.
Definitions and creation date are as follows:
(All definitio
Hi Takiguchi-san,
Can you please elaborate the rationale for the change? It looks like
IBM943 chaset hasn't changed for a long time, at least from JDK8. Has
the mapping definition recently changed?
Naoto
On 2/17/20 10:23 AM, Ichiroh Takiguchi wrote:
Hello.
Could you review the fix ?
Bug:
Hello.
Could you review the fix ?
Bug:https://bugs.openjdk.java.net/browse/JDK-8235834
Change: https://cr.openjdk.java.net/~itakiguchi/8235834/webrev.00/
IBM-943 is for IBM Japanese PC encoding.
MS932 is for Microsoft Japanese Windows encoding.
IBM-943 charset encoder does not contain 5 com
