Hi Letu,
Those translation drops are usually integrated at the end of the
development cycle, such as (for JDK 13):
https://bugs.openjdk.java.net/browse/JDK-8227009
And I don't think the issue is created for JDK 14 yet.
Naoto
On 12/9/19 10:04 AM, Yang, Letu wrote:
Thanks Naoto!
Is there a
Thanks Naoto!
Is there a separate ticket for the translation to other locales?
Letu
On 12/4/19, 12:36 PM, "naoto.s...@oracle.com" wrote:
Looks good, assuming the change between 03 and 04 is to fix "no new line..."
Naoto
On 12/4/19 11:38 AM, Yang, Letu wrote:
> Hi Nao
Looks good, assuming the change between 03 and 04 is to fix "no new line..."
Naoto
On 12/4/19 11:38 AM, Yang, Letu wrote:
Hi Naoto,
Can you review and approve the webrev? Thanks!
https://cr.openjdk.java.net/~xliu/8234288/webrev.04/
Letu
On 11/23/19, 6:09 PM, "naoto.s...@oracle.com" wrote:
Hi Naoto,
Can you review and approve the webrev? Thanks!
https://cr.openjdk.java.net/~xliu/8234288/webrev.04/
Letu
On 11/23/19, 6:09 PM, "naoto.s...@oracle.com" wrote:
Looks good.
Naoto
On 11/22/19 9:55 PM, Yang, Letu wrote:
> Hi Naoto,
>
> Added it in the
hanks!
From: Martin Buchholz
Date: Monday, November 25, 2019 at 10:27 AM
To: "Yang, Letu"
Cc: "core-libs-dev@openjdk.java.net" ,
"i18n-...@openjdk.java.net" ,
"naoto.s...@oracle.com" , Leo Jiang
, "Liu, Xin"
Subject: Re: Tu
; , Leo Jiang
, "Liu, Xin"
Subject: Re: Turkish Time Zone name string and translation
\ No newline at end of file
Please fix.
\ No newline at end of file
Please fix.
Looks good.
Naoto
On 11/22/19 9:55 PM, Yang, Letu wrote:
Hi Naoto,
Added it in the new webrev
https://cr.openjdk.java.net/~xliu/8234288/webrev.03/ . Thanks!
Letu
On Nov 22, 2019 4:40 PM, naoto.s...@oracle.com wrote:
Hi Letu,
You might want to add lines for "Turkey" zone as well in Locale
Hi Naoto,
Added it in the new webrev https://cr.openjdk.java.net/~xliu/8234288/webrev.03/
. Thanks!
Letu
On Nov 22, 2019 4:40 PM, naoto.s...@oracle.com wrote:
Hi Letu,
You might want to add lines for "Turkey" zone as well in LocaleData?
Naoto
On 11/22/19 4:16 PM, Yang, Letu wrote:
> Hi Naot
Hi Letu,
You might want to add lines for "Turkey" zone as well in LocaleData?
Naoto
On 11/22/19 4:16 PM, Yang, Letu wrote:
Hi Naoto,
Thank you for the advice! I've uploaded a new version:
https://cr.openjdk.java.net/~xliu/8234288/webrev.02/webrev/
Letu
On 11/21/19, 9:18 AM, "naoto.s...@or
Hi Naoto,
Thank you for the advice! I've uploaded a new version:
https://cr.openjdk.java.net/~xliu/8234288/webrev.02/webrev/
Letu
On 11/21/19, 9:18 AM, "naoto.s...@oracle.com" wrote:
Hi Letu,
The change in the resource bundle file looks good.
As to the regression test,
Hi Letu,
The change in the resource bundle file looks good.
As to the regression test, I would avoid adding a separate file, instead
add some variations for
open/test/jdk/sun/text/resources/LocaleDataTest.java as I mentioned. Add
some lines in "LocaleData" file, which contains the expected re
Hi Naoto,
Thank you for the suggestions!
I've added a new webrev: https://cr.openjdk.java.net/~xliu/8234288/webrev.01/
Letu
On 11/18/19, 9:09 AM, "naoto.s...@oracle.com" wrote:
Hi Letu,
Here are my comments to your changes:
- You will need a regression test for this fi
You'd have to look at the spec. For most names a pattern plus the country
name is used. That can be overridden with a non-composed name where needed.
{phone}
On Sun, Nov 17, 2019, 21:50 Martin Buchholz wrote:
> I've always wondered how the timezone-related translations are managed.
> CLDR seems
Could you file a ticket at
https://unicode-org.atlassian.net/ ?
{phone}
On Mon, Nov 18, 2019, 16:02 wrote:
> Thanks, Mark.
>
> Apparently there seems to be a bug in CLDR converter code, which cannot
> generate the localized names for "Turkey" metazone. Thus the localized
> names from the legacy
I should have been clearer, but the bug seems to be in the JDK tool
which converts CLDR's xml into JDK's resource bundles. I implemented the
CLDR's time zone names fallback spec with
https://bugs.openjdk.java.net/browse/JDK-8181157, but again there seems
to be a bug in the code.
Filed a JDK b
Hi Letu,
Here are my comments to your changes:
- You will need a regression test for this fix. Take a look at
test/jdk/sun/text/resources/LocaleDataTest.java, and add appropriate
test cases.
- Fix comment should follow the OpenJDK changeset guideline [1]
- As to the change itself, I would p
Thanks, Mark.
Apparently there seems to be a bug in CLDR converter code, which cannot
generate the localized names for "Turkey" metazone. Thus the localized
names from the legacy COMPAT locale data are being used. I will look
into it.
Apart from this, what Letu found out stands by itself as
Hi Naoto,
Thank you for the clarification!
Xin from my team has filed a JBS and uploaded my webrev:
https://bugs.openjdk.java.net/browse/JDK-8234288
https://cr.openjdk.java.net/~xliu/8234288/webrev.00/
Letu
On 11/16/19, 6:44 AM, "naoto.s...@oracle.com" wrote:
Letu,
Please go ahe
I've always wondered how the timezone-related translations are managed.
CLDR seems to be the master repository of such data, and projects like
OpenJDK are simply supposed to import that data.
But I looked at the CLDR sources, and there doesn't seem to be any "Turkey
Time" strings defined like there
Letu,
Please go ahead and fix the issue in English resource. As to the
translation, Oracle l10n will translate it in appropriate locales.
Naoto
On 11/15/19 5:56 PM, Yang, Letu wrote:
Hi Naoto
Thank you for the quick response! We will file a ticket later today.
Shall we make an effort on fi
Hi Letu,
Please file a JBS issue for this (component: core-libs, subcomponent:
java.util:i18n).
Naoto
On 11/15/19 3:19 PM, Yang, Letu wrote:
Hi,
We recently found an issue with the Time Zone name for “Europe/Istanbul” and
"Asian/Istanbul". Since Turkey moved to their own Turkish Time (TRT)
Hi,
We recently found an issue with the Time Zone name for “Europe/Istanbul” and
"Asian/Istanbul". Since Turkey moved to their own Turkish Time (TRT) zone in
2016, although the tzdata had been updated, the Time Zone name string has not
been updated yet:
https://hg.openjdk.java.net/jdk/jdk/file
23 matches
Mail list logo
