Re: 8020292: j.u.SplittableRandom

2013-08-27 Thread Paul Sandoz
On Aug 27, 2013, at 8:54 AM, Peter Levart wrote: > Hi, > > The system property name "java.util.secureRandomSeed" suggests that it is not > for SplittableRandom only. Now that ThreadLocalRandom is algorithmically > aligned with SplittableRandom, should initial seed for TLR instances also use

Re: 8020292: j.u.SplittableRandom

2013-08-26 Thread Peter Levart
Hi, The system property name "java.util.secureRandomSeed" suggests that it is not for SplittableRandom only. Now that ThreadLocalRandom is algorithmically aligned with SplittableRandom, should initial seed for TLR instances also use the same algorithm? Regards, Peter On 08/19/2013 01:06 PM,

hg: jdk8/tl/jdk: 8020292: j.u.SplittableRandom

2013-08-26 Thread paul . sandoz
Changeset: 5ce9025c9e1a Author:psandoz Date: 2013-08-26 22:55 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5ce9025c9e1a 8020292: j.u.SplittableRandom Reviewed-by: mduigou Contributed-by: Guy Steele , Doug Lea , Brian Goetz , Paul Sandoz + src/share/classes/java/util

Re: 8020292: j.u.SplittableRandom

2013-08-26 Thread Mike Duigou
With most recent changes, +1. Mike On Aug 19 2013, at 04:06 , Paul Sandoz wrote: > Hi, > > This is the patch for SplittableRandom: > > http://cr.openjdk.java.net/~psandoz/tl/JDK-8020292-SplittableRandom/webrev/ > > The algorithm remains the same as reported by Doug on the 9th August: > > h

Re: 8020292: j.u.SplittableRandom

2013-08-21 Thread Paul Sandoz
On Aug 21, 2013, at 12:19 PM, Doug Lea wrote: > On 08/21/2013 05:43 AM, Paul Sandoz wrote: >> On Aug 20, 2013, at 11:50 PM, Mike Duigou wrote: > - Additional seed material might be desirable for "seeder". I worry > about how many of the actual bits are random. > > Backing up a bit: I tri

Re: 8020292: j.u.SplittableRandom

2013-08-21 Thread Doug Lea
On 08/21/2013 05:43 AM, Paul Sandoz wrote: On Aug 20, 2013, at 11:50 PM, Mike Duigou wrote: - Additional seed material might be desirable for "seeder". I worry about how many of the actual bits are random. Backing up a bit: I tried using a SecureRandom seed. But then discovered that on some s

Re: 8020292: j.u.SplittableRandom

2013-08-21 Thread Paul Sandoz
On Aug 20, 2013, at 11:50 PM, Mike Duigou wrote: >>> - Additional seed material might be desirable for "seeder". I worry about >>> how many of the actual bits are random. If no local host address is >>> available the seed might be fairly predictable. In the murmur3 >>> implementation I included

Re: 8020292: j.u.SplittableRandom

2013-08-20 Thread Mike Duigou
On Aug 20 2013, at 04:57 , Paul Sandoz wrote: > [resending unsigned, sorry if a dup arrives later on] > > On Aug 19, 2013, at 9:04 PM, Mike Duigou wrote: > >> Looks pretty good. Two points concern me: >> >> - Every source of non-crypto quality randoms should explicitly document that >> it sh

Re: 8020292: j.u.SplittableRandom

2013-08-20 Thread Paul Sandoz
[resending unsigned, sorry if a dup arrives later on] On Aug 19, 2013, at 9:04 PM, Mike Duigou wrote: > Looks pretty good. Two points concern me: > > - Every source of non-crypto quality randoms should explicitly document that > it should not be used for generating keys or other crypto purpose

Re: 8020292: j.u.SplittableRandom

2013-08-19 Thread Mike Duigou
Looks pretty good. Two points concern me: - Every source of non-crypto quality randoms should explicitly document that it should not be used for generating keys or other crypto purposes. There is mention that the seeding is insecure in the implementation docs but more explicit mention in the pu

8020292: j.u.SplittableRandom

2013-08-19 Thread Paul Sandoz
Hi, This is the patch for SplittableRandom: http://cr.openjdk.java.net/~psandoz/tl/JDK-8020292-SplittableRandom/webrev/ The algorithm remains the same as reported by Doug on the 9th August: http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-August/019768.html Paul.