Re: 8141652 : Rename methods Objects.nonNullElse* to requireNonNullElse*

On 10 Nov 2015, at 18:55, Roger Riggs wrote: > A few of the proposed replacements of ?: with requireNonNullElse were > unsuitable > because in the particular context, null is an allowed replacement value. > > The webrev has been updated to revert changes: > - two uses

Re: 8141652 : Rename methods Objects.nonNullElse* to requireNonNullElse*

Hi Chris, Thanks for the review. On 11/11/15 6:17 AM, Chris Hegarty wrote: On 10 Nov 2015, at 18:55, Roger Riggs wrote: A few of the proposed replacements of ?: with requireNonNullElse were unsuitable because in the particular context, null is an allowed replacement

Re: 8141652 : Rename methods Objects.nonNullElse* to requireNonNullElse*

A few of the proposed replacements of ?: with requireNonNullElse were unsuitable because in the particular context, null is an allowed replacement value. The webrev has been updated to revert changes: - two uses in jdk/src/java.base/share/classes/java/time/format/DateTimePrintContext.java

Re: 8141652 : Rename methods Objects.nonNullElse* to requireNonNullElse*

Hi Stephen, On 11/6/2015 10:42 PM, Stephen Colebourne wrote: Seems fine to me. I would have inlined the ZoneId change to one line: String id = Objects.requireNonNullElse(aliasMap.get(zoneId), zoneId); to avoid the local variable change, but no big deal. Stephen Thanks, I'll fix that. Roger

Re: 8141652 : Rename methods Objects.nonNullElse* to requireNonNullElse*

Seems fine to me. I would have inlined the ZoneId change to one line: String id = Objects.requireNonNullElse(aliasMap.get(zoneId), zoneId); to avoid the local variable change, but no big deal. Stephen On 6 November 2015 at 20:24, Roger Riggs wrote: > Please review the

8141652 : Rename methods Objects.nonNullElse* to requireNonNullElse*

Please review the renaming of java.util.Object methods, the new method names are: public static T requireNonNullElse(T obj, T defaultObj); public static T requireNonNullElseGet(T obj, SupplierT> supplier); The only remaining possible gotcha for developers is the requireNonNull(T,