Re: RFR: 8153666: Optimize Formatter.formatMessage

2016-06-08 Thread Martin Buchholz
Thanks, Daniel. I only gave it a quick look, but Looks Good To Me.

Re: 8153666: Optimize Formatter.formatMessage

2016-06-08 Thread Daniel Fuchs
Hi Jason, On 08/06/16 16:39, Daniel Fuchs wrote: I will log a new issue for this - as as you say it appears to have little to do with what this patch is about. I have logged 8159070: Null pointer handling in java.util.logging.Logger is under tested and may not always conform to speci

Re: RFR: 8153666: Optimize Formatter.formatMessage

2016-06-08 Thread Daniel Fuchs
Thanks Roger. Here is an updated webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8153666/webrev.01 best regards, -- daniel On 08/06/16 15:56, Roger Riggs wrote: +1 On 6/8/2016 10:37 AM, Daniel Fuchs wrote: On 08/06/16 15:35, Roger Riggs wrote: Yes, I would update the spec to the new b

Re: RFR: 8153666: Optimize Formatter.formatMessage

2016-06-08 Thread Roger Riggs
Looks good, Thanks, Roger On 6/8/2016 11:47 AM, Daniel Fuchs wrote: Thanks Roger. Here is an updated webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8153666/webrev.01 best regards, -- daniel On 08/06/16 15:56, Roger Riggs wrote: +1 On 6/8/2016 10:37 AM, Daniel Fuchs wrote: On 08/06

Re: RFR: 8153666: Optimize Formatter.formatMessage

2016-06-08 Thread Daniel Fuchs
Thanks Roger. Here is an updated webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8153666/webrev.01 best regards, -- daniel On 08/06/16 15:56, Roger Riggs wrote: +1 On 6/8/2016 10:37 AM, Daniel Fuchs wrote: On 08/06/16 15:35, Roger Riggs wrote: Yes, I would update the spec to the new b

Re: 8153666: Optimize Formatter.formatMessage

2016-06-08 Thread Daniel Fuchs
ut. best regards, -- daniel Thanks, Jason From: core-libs-dev on behalf of Daniel Fuchs Sent: Wednesday, June 8, 2016 8:46 AM To: core-libs-dev Subject: RFR: 8153666: Optimize Formatter.formatMessage Hi, Please find below a patch for a small optimization in Formatter.formatMessage. This pa

Re: RFR: 8153666: Optimize Formatter.formatMessage

2016-06-08 Thread Roger Riggs
hich has become needless. More background available at: https://bugs.openjdk.java.net/browse/JDK-8153666 (thanks Martin!) and http://stackoverflow.com/questions/36433146/why-is-the-formatmessage-method-in-java-util-logging-formatter-synchronized (thanks Jason!) bug: 8153666: Optimize Formatter

Re: RFR: 8153666: Optimize Formatter.formatMessage

2016-06-08 Thread Daniel Fuchs
/browse/JDK-8153666 (thanks Martin!) and http://stackoverflow.com/questions/36433146/why-is-the-formatmessage-method-in-java-util-logging-formatter-synchronized (thanks Jason!) bug: 8153666: Optimize Formatter.formatMessage https://bugs.openjdk.java.net/browse/JDK-8153666 patch: http://cr.openjdk.java.net/~dfuch

Re: RFR: 8153666: Optimize Formatter.formatMessage

2016-06-08 Thread Roger Riggs
e at: https://bugs.openjdk.java.net/browse/JDK-8153666 (thanks Martin!) and http://stackoverflow.com/questions/36433146/why-is-the-formatmessage-method-in-java-util-logging-formatter-synchronized (thanks Jason!) bug: 8153666: Optimize Formatter.formatMessage https://bugs.openjdk.java.n

Re: RFR: 8153666: Optimize Formatter.formatMessage

2016-06-08 Thread Daniel Fuchs
w.com/questions/36433146/why-is-the-formatmessage-method-in-java-util-logging-formatter-synchronized (thanks Jason!) bug: 8153666: Optimize Formatter.formatMessage https://bugs.openjdk.java.net/browse/JDK-8153666 patch: http://cr.openjdk.java.net/~dfuchs/webrev_8153666/webrev.00 best rega

Re: 8153666: Optimize Formatter.formatMessage

2016-06-08 Thread Jason Mehrens
ld be generated and is trapped. For sure having tests for null message with and without a resource bundle would be a good idea. Thanks, Jason From: core-libs-dev on behalf of Daniel Fuchs Sent: Wednesday, June 8, 2016 8:46 AM To: core-libs-dev Subject: RFR: 8153666: Optimize Formatter.forma

Re: RFR: 8153666: Optimize Formatter.formatMessage

2016-06-08 Thread Roger Riggs
orical reasons - but which has become needless. More background available at: https://bugs.openjdk.java.net/browse/JDK-8153666 (thanks Martin!) and http://stackoverflow.com/questions/36433146/why-is-the-formatmessage-method-in-java-util-logging-formatter-synchronized (thanks J

RFR: 8153666: Optimize Formatter.formatMessage

2016-06-08 Thread Daniel Fuchs
Martin!) and http://stackoverflow.com/questions/36433146/why-is-the-formatmessage-method-in-java-util-logging-formatter-synchronized (thanks Jason!) bug: 8153666: Optimize Formatter.formatMessage https://bugs.openjdk.java.net/browse/JDK-8153666 patch: http://cr.openjdk.java.net/~dfuchs/webrev_8153666