Re: 8172971: java.management could use System.Logger

2017-01-20 Thread Mandy Chung
> On Jan 20, 2017, at 5:07 AM, Daniel Fuchs wrote: > > The rest is unchanged (only test changes). > > http://cr.openjdk.java.net/~dfuchs/webrev_8172971/webrev.01/ > +1 Mandy

Re: 8172971: java.management could use System.Logger

2017-01-20 Thread Daniel Fuchs
Hi Mandy, On 19/01/17 19:07, Mandy Chung wrote: This test should have @modules java.logging and java.management. OK - I believed @modules java.management should already be in TEST.ROOT I will double check. If @modules is specified in a test, it will override the one in TEST.properties (I thin

Re: 8172971: java.management could use System.Logger

2017-01-19 Thread Mandy Chung
> On Jan 19, 2017, at 10:50 AM, Daniel Fuchs wrote: > > Hi Mandy, > > Thanks for the review! > > On 19/01/17 17:12, Mandy Chung wrote: >> >> >> Is it intentional to change the level FINEST to DEBUG as opposed to TRACE in >> a couple places? For example, > > The regular mapping would be: >

Re: 8172971: java.management could use System.Logger

2017-01-19 Thread Daniel Fuchs
he changes much more difficult to review. best regards, -- daniel Roger On 1/19/2017 12:12 PM, Mandy Chung wrote: On Jan 19, 2017, at 7:30 AM, Daniel Fuchs wrote: Hi, Please find below a patch for: 8172971: java.management could use System.Logger https://bugs.openjdk.java.net/browse/

Re: 8172971: java.management could use System.Logger

2017-01-19 Thread Daniel Fuchs
Hi Mandy, Thanks for the review! On 19/01/17 17:12, Mandy Chung wrote: On Jan 19, 2017, at 7:30 AM, Daniel Fuchs wrote: Hi, Please find below a patch for: 8172971: java.management could use System.Logger https://bugs.openjdk.java.net/browse/JDK-8172971 webrev: http://cr.openjdk.java.net

Re: 8172971: java.management could use System.Logger

2017-01-19 Thread Roger Riggs
hung wrote: On Jan 19, 2017, at 7:30 AM, Daniel Fuchs wrote: Hi, Please find below a patch for: 8172971: java.management could use System.Logger https://bugs.openjdk.java.net/browse/JDK-8172971 webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8172971/webrev.00/ This looks good in general an

Re: 8172971: java.management could use System.Logger

2017-01-19 Thread Mandy Chung
> On Jan 19, 2017, at 7:30 AM, Daniel Fuchs wrote: > > Hi, > > Please find below a patch for: > > 8172971: java.management could use System.Logger > https://bugs.openjdk.java.net/browse/JDK-8172971 > > webrev: > http://cr.openjdk.java.net/~dfuchs/webrev_81729

8172971: java.management could use System.Logger

2017-01-19 Thread Daniel Fuchs
Hi, Please find below a patch for: 8172971: java.management could use System.Logger https://bugs.openjdk.java.net/browse/JDK-8172971 webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8172971/webrev.00/ I have also added a new test: test/sun/management/LoggingTest/LoggingTest.java This is a