Re: 8226242 : Diagnostic output for posix_spawn failure

Hi David, The error that is being reported is the absence of an ack from jsspawnhelper (CHILD_IS_ALIVE) indicating that it has started (and is about to exec the target exe). The child process should continue to run; reporting the status of the child will hopefully lead to identifying why the

Re: 8226242 : Diagnostic output for posix_spawn failure

Hi Roger, On 18/06/2019 6:00 am, Roger Riggs wrote: Hi, Updated: http://cr.openjdk.java.net/~rriggs/webrev-spawn-diag-8225192-3/ + if (WIFEXITED(status)) { + snprintf(ebuf, sizeof ebuf, + "Failed to exec spawn helper: pid: %d, exit value: %d", + pid,

Re: 8226242 : Diagnostic output for posix_spawn failure

Hi, Updated: http://cr.openjdk.java.net/~rriggs/webrev-spawn-diag-8225192-3/ On 6/17/19 2:20 PM, Martin Buchholz wrote: On Mon, Jun 17, 2019 at 10:47 AM Thomas Stüfe > wrote: Hi Roger, I think this is fine. Could you please also print out

Re: 8226242 : Diagnostic output for posix_spawn failure

On Mon, Jun 17, 2019 at 10:47 AM Thomas Stüfe wrote: > Hi Roger, > > I think this is fine. > > Could you please also print out WIFEXITED and WIFSIGNALLED? Since I am not > sure if the WEXITSTATUS contains valid info if WIFEXITED is 0, or just > random noise. Same for WTERMSIG. > > Alternatively:

Re: 8226242 : Diagnostic output for posix_spawn failure

Hi Roger, I think this is fine. Could you please also print out WIFEXITED and WIFSIGNALLED? Since I am not sure if the WEXITSTATUS contains valid info if WIFEXITED is 0, or just random noise. Same for WTERMSIG. Alternatively: if (WIFEXITED) print("exited normaly with %d", WEXITSTATUS) else if

Re: 8226242 : Diagnostic output for posix_spawn failure

Hi Thomas, yes, I meant WTERMSIG.  I figured the useful info was the value of those two fields of the status but a bit easier to read than the hex formatted value. If there is any other information available at that point of execution, let me know. Thanks, Roger [1]

Re: 8226242 : Diagnostic output for posix_spawn failure

Hi Roger, thanks for taking care of this! I think WIFSIGNALED is just a bool though; to get the terminating signal, you need to use WTERMSIG. Strictly speaking, WEXISTSTATUS is only valid if WIFEXITED!=0 and WTERMSIG only if WIFSIGNALLED!=0; I think they are undefined otherwise. Cheers, Thoams

Re: 8226242 : Diagnostic output for posix_spawn failure

Hi Roger, Looks good. Brian > On Jun 17, 2019, at 9:03 AM, Roger Riggs wrote: > > Please review adding diagnostic information to the native code handing > failures > to exec the jspawnhelper. Some information about the child process status > can be included. > > Jira: > diag task:

8226242 : Diagnostic output for posix_spawn failure

Please review adding diagnostic information to the native code handing failures to exec the jspawnhelper.  Some information about the child process status can be included. Jira:   diag task: https://bugs.openjdk.java.net/browse/JDK-8226242   Issue: