Looks good!
- Alexey
On 2/20/2020 9:53 AM, Baesken, Matthias wrote:
Thanks, just posted
8238947: tools/jpackage tests fail with old rpmbuild versions
https://bugs.openjdk.java.net/browse/JDK-8238947
http://cr.openjdk.java.net/~mbaesken/webrevs/8238947.0/
Best regards, Matthias
There is
Christoph
-Original Message-
From: Baesken, Matthias
Sent: Dienstag, 18. Februar 2020 16:55
To: Langer, Christoph ; core-libs-
d...@openjdk.java.net; Alexey Semenyuk
Subject: RE: 8238953: tools/jpackage tests do not work on Ubuntu Linux
Ok why not, new webrev :
http://cr.openjdk.j
;disabledPackagers")).orElse(
> >>> TKit.isUbuntu() ? Set.of("rpm") :
> >>> Collections.emptySet());
> >>>
> >>> Best regards
> >>> Christoph
> >>>
> >>>> -Original Message-
&g
: 8238953: tools/jpackage tests do not work on Ubuntu Linux
Ok why not, new webrev :
http://cr.openjdk.java.net/~mbaesken/webrevs/8238953.2/
Thanks, Matthias
Hi Matthias,
you could improve the patch a bit by starting TKit:: isUbuntu() with
if (!isLinux()) {
return false;
}
And then
Hi Matthias,
Looks good to me now.
Cheers
Christoph
> -Original Message-
> From: Baesken, Matthias
> Sent: Dienstag, 18. Februar 2020 16:55
> To: Langer, Christoph ; core-libs-
> d...@openjdk.java.net; Alexey Semenyuk
> Subject: RE: 8238953: tools/jpackage tests do
regards
> Christoph
>
> > -Original Message-
> > From: core-libs-dev On Behalf
> > Of Baesken, Matthias
> > Sent: Dienstag, 18. Februar 2020 09:14
> > To: core-libs-dev@openjdk.java.net; Alexey Semenyuk
> >
> > Subject: [CAUTION] RE:
: Thu, 13 Feb 2020 08:06:44 -0800
From: Alexey Semenyuk
To: core-libs-dev@openjdk.java.net
Subject: Re: RFR: 8238953: tools/jpackage tests do not work on Ubuntu
Linux
Message-ID: <0400cf9e-df43-b217-26b0-f9bb0fd1a...@oracle.com>
Content-Type: text/plain; charset=utf-8; format=flow
v@openjdk.java.net; Alexey Semenyuk
>
> Subject: [CAUTION] RE: 8238953: tools/jpackage tests do not work on
> Ubuntu Linux
>
> Ping ... are you fine with the latest version ?
>
> Best Regards, Matthias
>
> >
> > Hi Alexey , I like your idea to do the handling in
Ping ... are you fine with the latest version ?
Best Regards, Matthias
>
> Hi Alexey , I like your idea to do the handling in
> test/jdk/tools/jpackage/helpers/jdk/jpackage/test/PackageType.java .
>
> New webrev :
>
> http://cr.openjdk.java.net/~mbaesken/webrevs/8238953.1/
>
>
>
> Best r
pers/jdk/jpackage/test/PackageType.java .
>
> New webrev :
>
> http://cr.openjdk.java.net/~mbaesken/webrevs/8238953.1/
>
>
>
> Best regards, Matthias
>
>
> > Date: Thu, 13 Feb 2020 08:06:44 -0800
> > From: Alexey Semenyuk
> > To: core-libs-dev@ope
To: core-libs-dev@openjdk.java.net
> Subject: Re: RFR: 8238953: tools/jpackage tests do not work on Ubuntu
> Linux
> Message-ID: <0400cf9e-df43-b217-26b0-f9bb0fd1a...@oracle.com>
> Content-Type: text/plain; charset=utf-8; format=flowed
>
&g
Hi Matthias,
We don't set "jpackage.test.disabledPackagers" property from the test
code. It is assumed to be set from jtreg command line that runs tests.
The value of the property is just checked in tests.
So basically there is no need to change code at all.
However, if you want to disable run
Hello, please review this small test related change .
Currently (most of the) tools/jpackage tests do not work on Ubuntu Linux .
Reason is that the rpm parts of the jpackage tests do not pass on this distro
.
The rpm tests can be disabled by this property :
> >
> > Do you expect those
13 matches
Mail list logo
