Re: Character, Byte, Short valueOf instead of new instance

2014-07-11 Thread Remi Forax
On 07/02/2014 01:07 AM, Otávio Gonçalves de Santana wrote: Thank you Remi. The long[1] also was included? [1]https://bugs.openjdk.java.net/browse/JDK-8048267 yes, I've included all the patches (I hope) http://websvn.ow2.org/revision.php?repname=asm&path=%2Ftrunk%2F&rev=1759 There were just on

Re: Character, Byte, Short valueOf instead of new instance

2014-07-02 Thread Pavel Rappo
Andrej, Otavio, No need to do it. We've already done it. -Pavel On 1 Jul 2014, at 22:01, Andrej Golovnin wrote: > Could you please submit the ASM related changes to the ASM project [1]?

Re: Character, Byte, Short valueOf instead of new instance

2014-07-01 Thread Otávio Gonçalves de Santana
Thank you Remi. The long[1] also was included? [1]https://bugs.openjdk.java.net/browse/JDK-8048267 On Tue, Jul 1, 2014 at 7:28 PM, Remi Forax wrote: > > On 07/01/2014 11:01 PM, Andrej Golovnin wrote: > >> Hi Pavel, >> >> Thanks a lot! I've separated out all the changes from the >>> 'jdk.intern

Re: Character, Byte, Short valueOf instead of new instance

2014-07-01 Thread Remi Forax
On 07/01/2014 11:01 PM, Andrej Golovnin wrote: Hi Pavel, Thanks a lot! I've separated out all the changes from the 'jdk.internal.org.objectweb.asm' package. So I'll update both threads with new webrevs. http://cr.openjdk.java.net/~prappo/8048874/webrev.02 Looks good to me. @Otávio: Could

Re: Character, Byte, Short valueOf instead of new instance

2014-07-01 Thread Andrej Golovnin
Hi Pavel, > Thanks a lot! I've separated out all the changes from the > 'jdk.internal.org.objectweb.asm' package. So I'll update both threads with > new webrevs. > > http://cr.openjdk.java.net/~prappo/8048874/webrev.02 Looks good to me. @Otávio: Could you please submit the ASM related changes

Re: Character, Byte, Short valueOf instead of new instance

2014-07-01 Thread Pavel Rappo
Andrej, Thanks a lot! I've separated out all the changes from the 'jdk.internal.org.objectweb.asm' package. So I'll update both threads with new webrevs. http://cr.openjdk.java.net/~prappo/8048874/webrev.02 -Pavel On 1 Jul 2014, at 13:57, Andrej Golovnin wrote: > Hi Pavel, > > I'm sorry I

Re: Character, Byte, Short valueOf instead of new instance

2014-07-01 Thread Andrej Golovnin
Hi Pavel, I'm sorry I have totally forgotten to mention it. But I think that changes to the classes in the package "jdk.internal.org.objectweb.asm" should be done directly in the ASM library. In other case you may have conflicts when a new version of the ASM library is integrated into JDK next tim

Re: Character, Byte, Short valueOf instead of new instance

2014-07-01 Thread Pavel Rappo
Otavio, As with [1], I created an issue to track the progress and also made 2 webrevs. One for the original patch and one for the changes similar to those we discussed in [1]. https://bugs.openjdk.java.net/browse/JDK-8048874 http://cr.openjdk.java.net/~prappo/8048874/webrev.00 http://cr.openjd

Re: Character, Byte, Short valueOf instead of new instance

2014-06-26 Thread Chris Hegarty
Otavio, I scanner the patches and they mainly look fine to me. Just a minor issue, as per the Long thread. diff -r d02b062bc827 src/share/classes/com/sun/jndi/toolkit/dir/SearchFilter.java --- a/src/share/classes/com/sun/jndi/toolkit/dir/SearchFilter.java Fri Jun 13 11:21:30 2014 -0700 ++

Re: Character, Byte, Short valueOf instead of new instance

2014-06-18 Thread Otávio Gonçalves de Santana
Could anyone see my this path, please? On Sat, Jun 14, 2014 at 1:38 PM, Otávio Gonçalves de Santana < otavioj...@java.net> wrote: > Reason: The Character, Byte, Short classes have cache and using it, will > save memory and will faster than using create new instance. > > webrev: > https://dl.dro

Character, Byte, Short valueOf instead of new instance

2014-06-14 Thread Otávio Gonçalves de Santana
Reason: The Character, Byte, Short classes have cache and using it, will save memory and will faster than using create new instance. webrev: https://dl.dropboxusercontent.com/u/16109193/open_jdk/byte_short_character_value_of.zip similar: https://bugs.openjdk.java.net/browse/JDK-8044461 -- Atenc