Re[2]: Checking instanceof in DualPivotQuicksort

2019-11-01 Thread Vladimir Yaroslavskiy
Hi Brent, I agree with you, IllegalArgumentExceptions will help to catch invalid cases if we change the source in future. Please go ahead with integration. Thank you, Vladimir >25  Oct 2019, 8:28 +03:00 от Brent Christian : > >Hi, Vladimir > >I'd prefer to keep the code as is. Perhaps the exce

Re: Checking instanceof in DualPivotQuicksort

2019-10-24 Thread Brent Christian
Hi, Vladimir I'd prefer to keep the code as is. Perhaps the exception could help some other future maintainer to pinpoint a problem with a potential change. -Brent On 10/24/19 5:11 AM, Vladimir Yaroslavskiy wrote: Hi Brent, Looking at coverage of DualPivotQuicksort class, I found that case

Checking instanceof in DualPivotQuicksort

2019-10-24 Thread Vladimir Yaroslavskiy
Hi Brent, Looking at coverage of DualPivotQuicksort class, I found that cases of unexpected type of given array are not invoked at all (mentioned in my previous email). I think that these "else" can be removed, because method compute() of private classes are invoked from DualPivotQuicksort class